Change rerun button order #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
reviewed
May 8, 2024
Comment on lines
60
to
61
| const SizedBox(width: Spacing.level2), | ||
| _RerunButton(testExecution: testExecution), | ||
| const SizedBox(width: Spacing.level2), |
There was a problem hiding this comment.
perhaps we could either merge the SizedBox or remove one of them
There was a problem hiding this comment.
Seems like it was level4 before adding the Rerun button here, so I decided to restore it to level 4 here
Comment on lines
67
to
68
| _RerunButton(testExecution: testExecution), | ||
| const SizedBox(width: Spacing.level4), |
There was a problem hiding this comment.
the screenshot you supplied shows more spacing between rerun and signoff button than between signoff button and CI link. Perhaps we can reduce this spacing?
There was a problem hiding this comment.
Which one do you think fits best
spacing level 3
spacing level 2
There was a problem hiding this comment.
3 seems to strike a balance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change moves the rerun button from the left of the environment name to the right handside, just before the test execution review button.
This was suggested as a user experience improvement.
Screenshot