Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote celery task #180

Merged
merged 2 commits into from
May 10, 2024
Merged

Promote celery task #180

merged 2 commits into from
May 10, 2024

Conversation

omar-selo
Copy link
Collaborator

Resolves https://warthogs.atlassian.net/browse/RTW-199 (just need to remove the job from jenkins too after deployment)

Changes:

  • Move promote from endpoint to a celery task

andrejvelichkovski
andrejvelichkovski approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this improvement! Let's make sure to remove the jenkins job as well!

@omar-selo omar-selo merged commit a48a351 into main May 10, 2024
1 of 2 checks passed
@omar-selo omar-selo deleted the promote-celery-task branch May 10, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrejvelichkovski andrejvelichkovski andrejvelichkovski approved these changes

@nadzyah nadzyah Awaiting requested review from nadzyah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omar-selo @andrejvelichkovski