Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status update endpoint to receive updates from Testflinger #184

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Add status update endpoint to receive updates from Testflinger #184

merged 7 commits into from
Jul 26, 2024

Conversation

val500
Copy link
Collaborator

@val500 val500 commented Jun 7, 2024 •
edited
Loading

Changes:

  • Adds a new endpoint in POST /v1/test-executions/{test-execution-id}/status_update
  • Creates two new tables for storing status updates and their corresponding list of test events

@val500 val500 requested review from omar-selo and plars June 7, 2024 16:54
omar-selo
omar-selo requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments

backend/test_observer/data_access/models.py Outdated Show resolved Hide resolved
backend/test_observer/data_access/models.py Outdated Show resolved Hide resolved
backend/test_observer/controllers/test_executions/status_update.py Outdated Show resolved Hide resolved
backend/test_observer/controllers/test_executions/models.py Outdated Show resolved Hide resolved
@val500 val500 force-pushed the agent_status_update branch 2 times, most recently from 88a83e9 to 78a0518 Compare June 11, 2024 20:15
@val500 val500 marked this pull request as draft July 4, 2024 21:59
@val500 val500 force-pushed the agent_status_update branch 2 times, most recently from 42d5d77 to 885a4f1 Compare July 9, 2024 19:55
@val500 val500 marked this pull request as ready for review July 9, 2024 20:08
omar-selo
omar-selo reviewed Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty neat and clean! Just one comment and also can you please share a video recording of how it looks like

backend/test_observer/controllers/test_executions/models.py Show resolved Hide resolved
@val500 val500 force-pushed the agent_status_update branch 2 times, most recently from 0c60ea6 to fdb1784 Compare July 18, 2024 19:41
@omar-selo
Copy link
Collaborator

@val500 don't forget to attach a video of the frontend UI as otherwise it's difficult for me to imagine how it'll look like

@val500
Copy link
Collaborator Author

val500 commented Jul 22, 2024

@val500 don't forget to attach a video of the frontend UI as otherwise it's difficult for me to imagine how it'll look like
Here's the video:
test_observer_event_log.webm

@val500 val500 force-pushed the agent_status_update branch 2 times, most recently from c6d5472 to 975081e Compare July 22, 2024 16:39
plars
plars reviewed Jul 22, 2024
View reviewed changes
frontend/lib/ui/artefact_page/test_result_filter_expandable.dart Outdated
@@ -51,7 +51,7 @@ class TestResultsFilterExpandable extends ConsumerWidget {
),
children: filteredTestResults
.map(
(testResult) => TestResultExpandable(testResult: testResult),
(testResult) => TestResultExpandable(testResult: testResult),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unintended whitespace damage?

@omar-selo
Copy link
Collaborator

omar-selo commented Jul 23, 2024 •
edited
Loading

@val500 don't forget to attach a video of the frontend UI as otherwise it's difficult for me to imagine how it'll look like
Here's the video:
test_observer_event_log.webm

Nice I like the table. Just the left padding seems a bit off for some test executions/environments

image

@val500 val500 force-pushed the agent_status_update branch 2 times, most recently from dde4022 to 8c1bba9 Compare July 25, 2024 17:28
@val500 val500 requested a review from omar-selo July 25, 2024 19:05
@val500
Copy link
Collaborator Author

val500 commented Jul 26, 2024

test_observer_event_log
Updated artefact view - spacing is fixed and the latest event is shown next to each execution as described in the Jira ticket.

omar-selo
omar-selo approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for being patient and following up with our concerns!

@plars plars merged commit 07cadbb into main Jul 26, 2024
2 checks passed
@plars plars deleted the agent_status_update branch July 26, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plars plars plars left review comments

@nadzyah nadzyah nadzyah left review comments

@omar-selo omar-selo omar-selo approved these changes

@andrejvelichkovski andrejvelichkovski Awaiting requested review from andrejvelichkovski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@val500 @omar-selo @plars @nadzyah