Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artefact due date filters #190

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add artefact due date filters #190

merged 2 commits into from
Jul 17, 2024

Conversation

omar-selo
Copy link
Collaborator

Description

Adds a new artefacts filter based on due date.

Resolved issues

Resolves https://warthogs.atlassian.net/browse/RTW-324

Documentation

I don't think we have any documentation on filters.

Web service API changes

None

Tests

See below video:
Screencast from 2024-07-17 15-02-12.webm

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, really nice and clean implementation. I guess the background preparation we did for other filters helped us implement this one quite easily.

My only comment was about the "This week" option, as it is not really this week, but rather in a weeks time from now. So maybe we can rename the options to:

  • This week - In a week
  • Next week - In more than a week
  • Later than next week - In more than two weeks

Still, I'm not really sure what would be the best choice myself. Perhaps @jocave as a native-speaker should help us figure out the best wording for the choices.

@jocave
Copy link
Collaborator

jocave commented Jul 17, 2024

Wow, really nice and clean implementation. I guess the background preparation we did for other filters helped us implement this one quite easily.

My only comment was about the "This week" option, as it is not really this week, but rather in a weeks time from now. So maybe we can rename the options to:

  • This week - In a week
  • Next week - In more than a week
  • Later than next week - In more than two weeks

Still, I'm not really sure what would be the best choice myself. Perhaps @jocave as a native-speaker should help us figure out the best wording for the choices.

within a week
within two weeks
more than two weeks

?

@omar-selo
Copy link
Collaborator Author

omar-selo commented Jul 17, 2024

within a week
within two weeks
more than two weeks

Sounds clear and concise

Edit:
Actually second one is inclusive of the first so it doesn't work.

@omar-selo
Copy link
Collaborator Author

I suggest we go with "Within a week" and "More than a week" and drop "More than two weeks" because I don't think we can actually see that at all. IIRC no artefacts will have more than two weeks deadline

@andrejvelichkovski
Copy link
Contributor

I suggest we go with "Within a week" and "More than a week" and drop "More than two weeks" because I don't think we can actually see that at all. IIRC no artefacts will have more than two weeks deadline

Seems reasonable for now, we can follow-up if there are any concerns from others

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@omar-selo omar-selo merged commit 0a7c0a8 into main Jul 17, 2024
2 of 3 checks passed
@omar-selo omar-selo deleted the add-duedate-filters branch July 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants