Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard list view #193

Merged
merged 23 commits into from
Jul 30, 2024
Merged

Dashboard list view #193

merged 23 commits into from
Jul 30, 2024

Conversation

omar-selo
Copy link
Collaborator

Description

Changes:

  • Adds a list view mode for artefacts page
  • Upgrade flutter and yaru
    • Resolve color issues from upgrade
    • Re-create web directory using latest template

Resolved issues

Resolves https://warthogs.atlassian.net/browse/RTW-220

Documentation

None

Web service API changes

None

Tests

Manual tests. See also video and screenshots:
Screencast from 2024-07-26 15-26-00.webm

image

Screenshot from 2024-07-26 15-36-43

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One thing I really like about Flutter is how it is declarative and you can really re-use a lot of code. Also the hierarchy really makes sense as you start from the top going towards more specific implementation 😄

I only left a few small code-style comments, feel free to incorporate what you believe fits best.

frontend/lib/ui/dashboard/artefact_card.dart Outdated Show resolved Hide resolved
frontend/lib/ui/dashboard/artefact_card.dart Outdated Show resolved Hide resolved
frontend/lib/providers/view_mode.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments! Looks good to me!

@omar-selo omar-selo merged commit e5d67ae into main Jul 30, 2024
1 of 2 checks passed
@omar-selo omar-selo deleted the dashboard-list-view branch July 30, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants