Artefact page improvements #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since that now we don't have a legend, do you think we should add tooltips to the environment icons here:
|
andrejvelichkovski
previously approved these changes
Jul 31, 2024
Comment on lines
25
to
40
| child: Consumer( | ||
| builder: (context, ref, child) { | ||
| final artefactBuilds = | ||
| ref.watch(artefactBuildsProvider(artefact.id)); | ||
|
|
||
| return artefactBuilds.when( | ||
| loading: () => const YaruCircularProgressIndicator(), | ||
| error: (e, stack) => | ||
| Center(child: Text('Error:\n$e\nStackTrace:\n$stack')), | ||
| data: (artefactBuilds) => const PageFiltersView( | ||
| searchHint: 'Search by environment name', | ||
| width: double.infinity, | ||
| ), | ||
| ); | ||
| }, | ||
| ), |
There was a problem hiding this comment.
If I'm not wrong this code is rendering the side filter, do you think we can move it to a separate widget, perhaps a private one?
| 'Timestamp', | ||
| style: TextStyle(fontStyle: FontStyle.italic), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
It seems that here we have some formatting changes, should we rebase to main to use the formatter you added in the previous PR?
There was a problem hiding this comment.
There's no formatting changes here (already merged with main). But I've removed the SingleChildScrollView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bunch of improvements to artefact page:
Resolved issues
Resolves https://warthogs.atlassian.net/browse/RTW-335
Documentation
None
Web service API changes
None
Tests
See video below for the overall experience:
Screencast from 2024-07-30 14-05-18.webm
Image below for test event tooltip:
