Fix scroll resetting on rerun or review #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On artefact page, when you scroll then rerun or review an environment, the scroll position resets to the top. After lots of debugging turns out that the issues occurs because initially the
ArtefactPageBodywidget builds aListView. When you rerun or approve an artefact theArtefactPageBodybuilds aYaruCircularProgressIndicatorfor a split second before building aListViewagain. During this split second the older ListView is destroyed and together with it the scroll position on this page. To resolve the issue we avoid building aYaruCircularProgressIndicatorduring that split second. This can be done by using the filtered test executions provider's value property. This property will return the previous filtered test executions list while it's loading the changes of the rerun/review. Hence the ListView is always returned even when loading (at least not initially).Resolved issues
https://warthogs.atlassian.net/browse/RTW-344
Documentation
None
Web service API changes
None
Tests
Screencast from 2024-08-08 13-36-46.webm
Screencast from 2024-08-08 13-40-35.webm