Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case issue reporting #207

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Add test case issue reporting #207

merged 10 commits into from
Aug 30, 2024

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented Aug 29, 2024

Description

Adds model and endpoints to support reporting test case issues.

Resolved issues

Backend part of https://warthogs.atlassian.net/browse/RTW-355

Documentation

Web service API changes

New endpoints:

  • POST /v1/test-cases/reported-issues to create issues
  • GET /v1/test-cases/reported-issues?template_id&case_name to get issues (optionally ones belonging to particular template_id or a particular case_name)
  • PUT /v1/test-cases/reported-issues/id to update an issue
  • DELETE /v1/test-cases/reported-issues/id to delete an issue

Tests

Added automated tests.

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, however I left two small notes where I think we can improve the style.

My understanding from your explanation was that we would also have some kind of "confirming issues", so that when someone reports an issue, someone from the team would need to confirm it. Or maybe this was only for reporting issues to environments? I got confused between the two.

@omar-selo
Copy link
Collaborator Author

My understanding from your explanation was that we would also have some kind of "confirming issues", so that when someone reports an issue, someone from the team would need to confirm it. Or maybe this was only for reporting issues to environments? I got confused between the two.

You are right. As per spec, confirming issues is only for environments. It's assumed that when users create an issue on test cases, it's already confirmed. But environments are treated differently to allow a way for reviewers to tell certlab that something needs checking (e.g. machine is not provisioning, wifi keeps failing, etc.). Once certlab confirmed the issue they'd update it and mark it as confirmed.

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this! Looks really good, excited to see it landed :d

omar-selo and others added 2 commits August 30, 2024 16:36
Co-authored-by: Nadzeya H <[email protected]>
Co-authored-by: Nadzeya H <[email protected]>
@omar-selo omar-selo requested a review from nadzyah August 30, 2024 13:37
@omar-selo omar-selo merged commit 01bd669 into main Aug 30, 2024
1 of 2 checks passed
@omar-selo omar-selo deleted the add-test-case-issue-reporting branch August 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants