Don't create a tarbomb #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarbomb (archive without folder) is generaly a bad practice. Instead of: - mcfly - mcfly.bash - mcfly.fish - mcfly.zsh this will create: - mycfly - mcfly - mcfly.bash - mcfly.fish - mcfly.zsh I'm not sure of all impact of it (for hombrew for example).
|
Thanks @barmic! However, I think this might break Homebrew and users' install scripts. |
|
@barmic if you still have the energy to look at it, it would be great if this PR also included the changes to the Homebrew recipe and install documentation to go with the changed folder structure in the zip file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tarbomb (archive without folder) is generaly a bad practice.
Instead of:
this will create:
I'm not sure of all impact of it (for hombrew for example).