Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic customisation for menubar colors #343

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

V1RE
Copy link

@V1RE V1RE commented Mar 28, 2023

#156 looks promising, but hasn't seen much action in the last 2 years. So I
made a quick and simple way to customize the foreground and background colors of the menubar using env vars.

Haven't used rust too much, so lmk if I can improve on anything

@cantino
Copy link
Owner

cantino commented Apr 6, 2023

Thanks @V1RE! The only problem is if we merge this, we need to support these options even in an eventually, more configurable world. Perhaps thats fine though.

@cantino
Copy link
Owner

cantino commented Apr 6, 2023

Do you want to go through and wire up other color options too (text, background, highlight)?

@V1RE
Copy link
Author

V1RE commented Apr 6, 2023

Sure, what env vars should I use?

@cantino
Copy link
Owner

cantino commented Apr 7, 2023

MCFLY_PROMPT_COLOR, MCFLY_HIGHLIGHT_COLOR, MCFLY_SELECTION_COLOR might be all of them?

@V1RE
Copy link
Author

V1RE commented Apr 10, 2023

@cantino What to do with the lightmode setting? this would kind of make that obsolete, right?

@V1RE V1RE marked this pull request as draft April 11, 2023 08:25
@cantino
Copy link
Owner

cantino commented Jun 17, 2024

Can we integrate this with the new configuration system #407?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants