Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gradle 7 builds for capacitor 3 as recommended #195

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

riderx
Copy link
Contributor

@riderx riderx commented Jan 18, 2022

As say here : https://capacitorjs.com/docs/updating/3-0#update-gradle-to-70
Gradle 7 is the minium version for android, in capacitor 3.

@riderx riderx changed the title fix: Gradle 7 builds as recommended in capacitor android fix: Gradle 7 builds for capacitor 3 as recommended Jan 18, 2022
@pbowyer
Copy link
Collaborator

pbowyer commented Jan 31, 2022

Thank you @riderx for this long-anticipated change!

Could you please rebase your branch against master as Capacitor 3 support has been merged and is now the default.

@riderx riderx changed the base branch from capacitor-3 to master February 1, 2022 15:48
@riderx
Copy link
Contributor Author

riderx commented Feb 1, 2022

@pbowyer done !

@riderx
Copy link
Contributor Author

riderx commented Mar 2, 2022

@pbowyer any news on that ?

@pbowyer
Copy link
Collaborator

pbowyer commented Mar 2, 2022

I've had a mad month with work and not been able to test this yet; hoping March is calmer! Thanks for your patience - and the reminder 👍

@riderx
Copy link
Contributor Author

riderx commented Mar 3, 2022

@pbowyer hope for you too, it's never good when it last too much !

@pbowyer
Copy link
Collaborator

pbowyer commented Mar 6, 2022

Thanks, tested and it works great 😀

I think this is going to need the next release of camera preview to use a new major version number (v2.0 to v3.0), as everyone must upgrade their Gradle project to use this change. I tested using your PR on a project using Gradle 4 and it broke, so I don't think it is possible to be backwards compatible?

@riderx
Copy link
Contributor Author

riderx commented Mar 7, 2022

@pbowyer yes it's not backwards compatible

@pbowyer pbowyer merged commit 0e92f4d into capacitor-community:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants