-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/93 preview not resized and displayed correctly when orientation changes #238
Conversation
We have the same issue on ios i think @ryaa did you tried ? |
@ryaa i did merge your both PR in this repo and published it : |
@riderx, can you please try to install from my fork npm install ryaa/camera-preview#chore/my-latest-fixes-as-of-21-july-2022 |
@ryaa after second round of testing I can see an improvement. but still not as expected. https://drive.google.com/file/d/1awylwmhwq5oDWvtA8LNpcXLInbjLMmLC/view?usp=sharing |
interesting. as I understand, the problem is on an Android device, right? I will try to double check to see if I can reproduce this problem. Right now, it seems to be working ok on my end. |
@ryaa nope that on IOS |
This PR is for the fix for android and not iOS, so this is not relevant. Please note that the fix for iOS has already been merged to master and released - see https://github.com/capacitor-community/camera-preview/releases/tag/v3.1.1 |
@ryaa the title of the fix for iOS is "fixed the problem when photos taken in the landscape orientation are off" which is not my issue. |
ah.. got it... question - are you having the problem with the plugin installed from my branch (as I indicated above)? or is this the plugin installed from your branch? |
@ryaa i tried with both and the behavior is the same, who seems normal since my branch is ISO as yours. ^^ |
Here is the change for iOS which fixes the rotation issue https://github.com/capacitor-community/camera-preview/pull/235/files |
@ryaa i have seen that change, for me this is the fix for "fixed the problem when photos taken in the landscape orientation are off" , but you mean that also fix when you rotate the camera that rotate the preview? |
@pbowyer when you have time to check that one, it seems important for android too :) |
@pbowyer if you need anything on this please ask :) |
thanks !
App MVP builder at Forgr <https://forgr.ee/>
Podcast host at INDIE MAKERS <https://indiemakers.fr>
Maker of Captime <https://captime.app> Crossfit timer app
Creator of Capgo <https://capgo.app/> Capacitor OTA system
On August 29, 2022, Martin DONADIEU ***@***.***> wrote:
Merged #238 <https://github.com/capacitor-community/camera-
preview/pull/238> into master.
—
Reply to this email directly, view it on GitHub
<#238 (comment)-
7278504235>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AA7FGLZ3PIIHWFTLLHBOXZDV3SZHDANCNFSM54EL3XZQ>.
You are receiving this because you were mentioned.Message ID:
<capacitor-community/camera-
***@***.***>
|
No description provided.