-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): made it work with Capacitor 4 #249
base: master
Are you sure you want to change the base?
Conversation
…ture-taken-in-landscape-orientation-is-captured-as-portrait-photo bugfix: fixed the problem when photos taken in the landscape orientat…
…not-resized-and-displayed-correctly-when-orientation-changes Bugfix/93 preview not resized and displayed correctly when orientation changes
Hey @trancee can you open your Pr to https://github.com/Cap-go/camera-preview i will merge it directly |
Hey there, any news on this PR? I am having some issues with this plugin on Capacitor 4 not sure if it is related to my issue I raised - #270 |
This comment was marked as spam.
This comment was marked as spam.
Thanks for your reply, this one here: https://github.com/riderx/camera-preview ? I checked out this issue.- Screenshot: Node version - |
you can just npm install it's published: |
Thanks, I have installed the package https://www.npmjs.com/package/@capgo/camera-preview and done an Console: Imports ... import { CameraPreview, CameraPreviewOptions, CameraPreviewPictureOptions } from "@capgo/camera-preview"; import '@capgo/camera-preview'; //web? ... Component ... const onStartCamera = async () => { const cameraPreviewOptions: CameraPreviewOptions = { position: 'rear', width: 1080, toBack: true }; await CameraPreview.start(cameraPreviewOptions); } ... Package.json cap related deps "@capacitor/android": "^4.6.1", "@capacitor/core": "^4.6.1", "@capacitor/filesystem": "^4.1.4", "@capacitor/geolocation": "^4.1.0", "@capacitor/ios": "^4.6.1", "@capacitor/preferences": "^4.0.2", "@capacitor/status-bar": "^4.1.1", "@capgo/camera-preview": "^3.5.1", "@codetrix-studio/capacitor-google-auth": "^3.2.0", |
refers to #243 and #247
format
onWeb
to choose which picture format should be outputquality
will default to85%
to achieve feature parity with other platformsplease kindly review my changes.