Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reproducibility text #231

Closed
aturner-epcc opened this issue Jul 29, 2024 · 0 comments · Fixed by #241
Closed

Improve reproducibility text #231

aturner-epcc opened this issue Jul 29, 2024 · 0 comments · Fixed by #241
Assignees
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review

Comments

@aturner-epcc
Copy link
Contributor

From the lesson peer review

Chapter 9: Something that is interesting regarding Docker container's reproducibility is the use of tags for the base images. You mention how to use them and that is not mandatory as well, but it could influence from the reproducibility side. Another topic that could be important to mention regarding reproducibility is whether it is convenient to pin the version of the Python - R - .... packages they want to use inside the containers. I know that there are no guidelines about how to do this (you said that in the lesson), but at least mentioning some benefits or cons of doing it (or not) could help future Docker users make their own decisions regarding this topic.
Also, using Docker images that are multiplatform can help with reproducibility as well.

@aturner-epcc aturner-epcc added the peer review:editorial comment Editorial comments to be addressed from the peer review label Jul 29, 2024
@jcohen02 jcohen02 self-assigned this Jul 31, 2024
jcohen02 added a commit to jcohen02/docker-introduction that referenced this issue Aug 1, 2024
aturner-epcc added a commit that referenced this issue Aug 16, 2024
Updates to the reproducibility section to address #231
github-actions bot pushed a commit that referenced this issue Aug 16, 2024
Auto-generated via {sandpaper}
Source  : 46dbcd2
Branch  : main
Author  : Andy Turner <[email protected]>
Time    : 2024-08-16 08:20:53 +0000
Message : Merge pull request #241 from jcohen02/fix/issue231

Updates to the reproducibility section to address #231
github-actions bot pushed a commit that referenced this issue Aug 16, 2024
Auto-generated via {sandpaper}
Source  : 444f6ca
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-16 08:21:40 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 46dbcd2
Branch  : main
Author  : Andy Turner <[email protected]>
Time    : 2024-08-16 08:20:53 +0000
Message : Merge pull request #241 from jcohen02/fix/issue231

Updates to the reproducibility section to address #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants