Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ownership override allowed apps flag dangerous #1008

Merged

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Aug 30, 2024

What this PR does / why we need it:

This PR makes it so that --dangerous-override-ownership-of-existing-resources is no longer required to do a scoped override.
The flag for scoped override - --dangerous-override-allowed-apps is not itself a dangerous flag which accepts a list of apps that ownership can be snatched from.

Does this PR introduce a user-facing change?

We need to update documentation with the new help message and flag name
Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good. I think we don't have a test for the existing --dangerous-override-ownserhip-of-existing-resources, can we please add one to ensure that there is no regression.

@praveenrewar
Copy link
Member

Also, please sign you commit :)

@100mik 100mik force-pushed the make-filtered-ownership-snatch-dangerous branch from b826da2 to c6b1232 Compare September 1, 2024 23:33
@100mik
Copy link
Contributor Author

100mik commented Sep 1, 2024

Done and done!

@100mik 100mik force-pushed the make-filtered-ownership-snatch-dangerous branch from c6b1232 to 1c7ccf3 Compare September 1, 2024 23:37
@100mik 100mik merged commit 2f318fc into carvel-dev:develop Sep 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants