Allow custom wait rules for kc resources #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppforlife
reviewed
Apr 22, 2024
| @@ -64,10 +64,5 @@ func (s KappctrlK14sIoV1alpha1App) IsDoneApplying() DoneApplyState { | |||
| } | |||
| } | |||
|
|
|||
| deletingRes := NewDeleting(s.resource) | |||
There was a problem hiding this comment.
note that the reason why this was set up this way (not saying it's ideal) is because above (line 61) is looking at delete conditions.
Signed-off-by: Praveen Rewar <[email protected]>
praveenrewar
force-pushed
the
converged-resource-deletion
branch
from
43dd7b7
to
1194285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: