Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron-job.yml #947

Merged
merged 1 commit into from
May 2, 2024
Merged

Update cron-job.yml #947

merged 1 commit into from
May 2, 2024

Conversation

jmcudd
Copy link
Contributor

@jmcudd jmcudd commented Apr 30, 2024

This change fixes this issue:

kapp: Error: Expected to find kind 'batch/v1beta1/CronJob', but did not:
- Kubernetes API server did not have matching apiVersion + kind
- No matching CRD was found in given configuration

This example is used in the docs here. https://carvel.dev/kapp-controller/docs/v0.50.x/packaging-tutorial/#optional-explore-kapp

@praveenrewar
Copy link
Member

Thank you @jmcudd for the fix. Could you please sign your commit so that we can accept this change.

This change fixes this issue:

```
kapp: Error: Expected to find kind 'batch/v1beta1/CronJob', but did not:
- Kubernetes API server did not have matching apiVersion + kind
- No matching CRD was found in given configuration
```

Signed-off-by: John Cudd <[email protected]>
@jmcudd jmcudd marked this pull request as draft April 30, 2024 14:31
@jmcudd jmcudd marked this pull request as ready for review April 30, 2024 14:32
@jmcudd
Copy link
Contributor Author

jmcudd commented Apr 30, 2024

Looks like #792 is related. I believe @satyampsoni was following the packaging tutorial as well.

@praveenrewar
Copy link
Member

Looks like #792 is related

Ah, that makes sense.

@praveenrewar praveenrewar linked an issue May 2, 2024 that may be closed by this pull request
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix!

@praveenrewar praveenrewar merged commit e7f1085 into carvel-dev:develop May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update cron-job.yml
2 participants