Add handling of updates to default values to the CRD Upgrade Safety preflight check #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everettraven
reviewed
May 2, 2024
everettraven
reviewed
May 2, 2024
100mik
reviewed
May 3, 2024
test/e2e/preflight_crdupgradesafety_invalid_field_change_default_added_test.go
Show resolved
Hide resolved
everettraven
reviewed
May 6, 2024
test/e2e/preflight_crdupgradesafety_valid_field_change_default_no_change_test.go
Show resolved
Hide resolved
|
@rashmigottipati Since I merged the other PR, this now has some merge conflicts. |
everettraven
approved these changes
May 8, 2024
…reflight check Signed-off-by: Rashmi Gottipati <[email protected]>
rashmigottipati
force-pushed
the
feature/default-value-change
branch
from
97a2589
to
9a9d23d
Compare
|
Thanks @everettraven for the approval! @praveenrewar Thanks for merging the other PR. Rebased this PR and squashed commits. |
100mik
approved these changes
May 8, 2024
There was a problem hiding this comment.
Looks good to me!
@praveenrewar merge away if you are fine with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds another field change validation to the CRD Upgrade Safety checks to prevent changes to a field's default values for a given CRD version during an upgrade and ensures the below:
Which issue(s) this PR fixes:
#949
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: