Point pinniped registry to ghcr.io #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: devanshuVmware <[email protected]>
rohitagg2020
reviewed
Jul 8, 2024
Signed-off-by: devanshuVmware <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>
rohitagg2020
approved these changes
Jul 8, 2024
praveenrewar
approved these changes
Jul 9, 2024
praveenrewar
pushed a commit
to praveenrewar/kapp
that referenced
this pull request
Jul 9, 2024
* Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]>
praveenrewar
pushed a commit
to praveenrewar/kapp
that referenced
this pull request
Jul 9, 2024
* Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]> Signed-off-by: Praveen Rewar <[email protected]>
devanshuVmware
added a commit
to devanshuVmware/kapp
that referenced
this pull request
Jul 9, 2024
* Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]>
devanshuVmware
added a commit
to devanshuVmware/kapp
that referenced
this pull request
Jul 9, 2024
* Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]>
devanshuVmware
added a commit
to devanshuVmware/kapp
that referenced
this pull request
Jul 9, 2024
* Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]>
rohitagg2020
added a commit
that referenced
this pull request
Jul 11, 2024
* Fixing redis image in test case (#976) Signed-off-by: Rohit Aggarwal <[email protected]> Co-authored-by: Rohit Aggarwal <[email protected]> Signed-off-by: devanshuVmware <[email protected]> * Point pinniped registry to ghcr.io (#977) * Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]> * Update redis image in gitops example Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: Rohit Aggarwal <[email protected]> Signed-off-by: devanshuVmware <[email protected]> Co-authored-by: rohitagg2020 <[email protected]> Co-authored-by: Rohit Aggarwal <[email protected]>
rohitagg2020
added a commit
that referenced
this pull request
Jul 11, 2024
* Point pinniped registry to ghcr.io (#977) * Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]> Signed-off-by: Praveen Rewar <[email protected]> * Fixing redis image in test case (#976) Signed-off-by: Rohit Aggarwal <[email protected]> Signed-off-by: Praveen Rewar <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]> Signed-off-by: Praveen Rewar <[email protected]> Co-authored-by: Devanshu <[email protected]> Co-authored-by: rohitagg2020 <[email protected]>
rohitagg2020
added a commit
that referenced
this pull request
Jul 11, 2024
* Fixing redis image in test case (#976) Signed-off-by: Rohit Aggarwal <[email protected]> Co-authored-by: Rohit Aggarwal <[email protected]> Signed-off-by: devanshuVmware <[email protected]> * Point pinniped registry to ghcr.io (#977) * Point pinniped registry to ghcr.io Signed-off-by: devanshuVmware <[email protected]> * Remove https from image value Signed-off-by: devanshuVmware <[email protected]> * Download latest pinniped config for external test Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: devanshuVmware <[email protected]> * Update redis image in gitops example Signed-off-by: devanshuVmware <[email protected]> --------- Signed-off-by: Rohit Aggarwal <[email protected]> Signed-off-by: devanshuVmware <[email protected]> Co-authored-by: rohitagg2020 <[email protected]> Co-authored-by: Rohit Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pinniped test cases fail in the kapp release job due to ImagePullBackOff Error
as projects.registry.vmware.com is no longer public.
This PR now points the pinniped image registry to ghcr.io
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: