Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set_target_properties's VERSION #237

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: set_target_properties's VERSION #237

merged 1 commit into from
Sep 11, 2023

Conversation

BA7LYA
Copy link
Contributor

@BA7LYA BA7LYA commented Sep 11, 2023

Fixes

#205

Description

In "./casbin/CMakeLists.txt", line 79~82,

set_target_properties(casbin PROPERTIES 
    PREFIX ""
    VERSION ${CMAKE_PROJECT_VERSION}
)

well, if i integrate casbin-cpp to my project as a thirdparty via cmake, the VERSION property will refer to my top project's VERSION property, cause CMAKE_PROJECT_VERSION means that, so it's unreasonable.

Instead, by

set_target_properties(casbin PROPERTIES 
    PREFIX ""
    VERSION ${PROJECT_VERSION}
)

the VERSION property will refer to casbin-cpp's top project's VERSION property, i think that's what we want.

@casbin-bot
Copy link
Member

@EmperorYP7 @sheny1xuan @cs1137195420 please review

Copy link
Member

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run this command to resolve the semantic PR CI error:

git commit --amend -m "fix: set_target_properties's VERSION"

@BA7LYA
Copy link
Contributor Author

BA7LYA commented Sep 11, 2023

Run this command to resolve the semantic PR CI error:

git commit --amend -m "fix: set_target_properties's VERSION"

Thanks for the tip :)

Copy link
Member

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @BA7LYA

@EmperorYP7 EmperorYP7 merged commit 242f616 into casbin:master Sep 11, 2023
14 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.54.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants