Sorting blindedMessages by amount #100
Conversation
|
This is now ready for review. As outline above I changed createSplitPayload to return a payload containing a list of proofs ordered by amount, as well as a list of booleans indicating which proof to keep and which to send. |
| amount: sendBlindedMessages.amounts[i], | ||
| keep: false | ||
| })); | ||
| const keepVector: Array<boolean> = []; | ||
| const blindedMessages: BlindedTransaction = { |
There was a problem hiding this comment.
let's rename this variable to blindedTransaction. blindedMessages seems kinda confusing. What do you think?
There was a problem hiding this comment.
Oh yes absolutely. Will do
| blindedMessages: [], | ||
| secrets: [], | ||
| rs: [], | ||
| amounts: [] |
There was a problem hiding this comment.
we could add the keep vector here instead
There was a problem hiding this comment.
True, I was not sure how many lines of code depend on the type BlindedTransaction and wanted to reduce this PRs footprint. But I will check that out in my next iteration.
I was under the assumption that the old units tests for this method would still suffice, but we should probably add one to check wether the amount is actually sorted (will do asap). Or am I missing something? |
What would be good way to easily generate secrets and signatures for the Unit tests? |
|
If you're only trying to test the sorting, you don't need valid secrets. It doesn't get validated anyways. You should be able to just mock it! |
Fixes: #90
Description
Ordered blindedMessages returned by createSplitPayload by amount and added a keepVector
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format