Bug: fix keyset or keysetId for receiveTokenEntry()
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we add optional keyset to other functions too? Usually it was thought that the keys get initialized with the wallet, so make a different instance for each keyset. But I am interested to know how other people are using it |
We could do both: take those the wallet got initialized with or an optional defined keyset and / or unit. Ideally this would be coherent across all relevant methods. I could do that, would you like me to? |
|
seems to be resolved in latest version fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug related to #123.
getKeys()used to fetchsatunit keysets per default which leads to errors when receiving a different unit.