Refactored types into a more organized hierarchy. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this alot. Thank you for doing this. However I think after merging this we need to take this even further for a later major release. As pointed out in #109 some Types are not unambiguous enough. Also thinks like We can still proceed with merging this change though, to clean things up a little |
callebtc
approved these changes
Jul 19, 2024
|
@cjbeery24 could you please rebase this PR to the |
cjbeery24
force-pushed
the
types-refactor
branch
from
5fa8ce7
to
8be0932
Compare
|
@Egge21M Okay, think I did that correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #109
Description
Refactored types into a more organized hierarchy.
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format