Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong redirect pressing QR icon in contacts screen #131

Closed
KKA11010 opened this issue Aug 19, 2023 · 4 comments · Fixed by #141
Closed

Wrong redirect pressing QR icon in contacts screen #131

KKA11010 opened this issue Aug 19, 2023 · 4 comments · Fixed by #141
Assignees
@KKA11010
Labels
bug Something isn't working completed 🌟 Changes are already available and have to be merged

Comments

@KKA11010
Copy link
Collaborator

Describe the bug
QR code icon takes me back to the home screen

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Contacts'
  2. Click on 'QR icon' in top nav
  3. See error

Expected behavior
Redirect to QR scan screen
@KKA11010 KKA11010 added the bug Something isn't working label Aug 19, 2023
@KKA11010 KKA11010 self-assigned this Aug 19, 2023
KKA11010 added a commit that referenced this issue Aug 19, 2023
@KKA11010
Fixes #131
9e721f8
@KKA11010 KKA11010 mentioned this issue Aug 19, 2023
Merged
@swedishfrenchpress
Copy link
Collaborator

This is fixed. The QR code redirects to the QR scan screen. One point: There is a haptic feedback when I click the X on the QR scan screen. Is that intentional?

@KKA11010
Copy link
Collaborator Author

yes it's intentional

@KKA11010 KKA11010 added the completed 🌟 Changes are already available and have to be merged label Aug 19, 2023
@swedishfrenchpress
Copy link
Collaborator

Okay, I would suggest to remove it, closing a scan/camera screen is a routine action. Adding haptic feedback might overemphasize its importance, making the user question whether they did something wrong or more significant than intended. but just my 2 sats.

@KKA11010
Copy link
Collaborator Author

removing it now

KKA11010 added a commit that referenced this issue Aug 19, 2023
@KKA11010
remove vibration on closing scan screen #131
6b4c9b5
KKA11010 added a commit that referenced this issue Aug 26, 2023
@KKA11010
Review (#141)
ab295a6 
* update app config

* Fixes #131

* Fixes #133

* fix mint url clipboard submit

* update invoice screen

* dont allow deleting a mint with remaining balance

* add factory reset, update contacts onboarding text

* update readme

* update nostr contacts screen. Fixes #132

* fix adding npub

* Fixes #128

* add missing translation in single contact screen

* Fixes #143

* add try catch for dropAll method

* fix

* #Fixes #135

* update pin hint (add "no restore" warning)

* remove vibration on closing scan screen #131

* update and use mainColors

* maintain the CTA conventions, see #132

* u SDK49 compatible deps, update truncate func

* clean up, add some JSDocs

* update truncated components

* update top-nav go-back btn in the left. Fixes #130

* update padding of top nav back icon

* Fixes #126

* Fix send button txt in payment overview screen

* fix sending process

* Add scrollable onboarding. Fixes #138

* fix navigation screen name

* add specific animations for auth and onboarding

* adapt nostr onboarding screen

* update onboarding translations

* show onboarding screen first

* update initial screen animations to default

* add apple bundle identifier

* update dashboard

* Add recipient (nostr) to history entry

* add nostr sender to history entry

* Add multimint swap as history entry

* add max 3 latest transaction to dashboard

* add settings to hide latest transactions

* update disclaimer screen

* update disclaimer txt

* add missing translations

* add production scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KKA11010 KKA11010

Labels
bug Something isn't working completed 🌟 Changes are already available and have to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review cashubtc/eNuts
2 participants
@KKA11010 @swedishfrenchpress