NUT-XX and NUT-XX+1: Mint / Melt Bitcoin On-Chain #107

ngutech21 · 2024-03-29T16:14:20Z

First draft for minting and melting tokens On-Chain.

gandlafbtc · 2024-03-29T17:03:39Z

looks great so far, nice work!

question about the minting

How do we know when the payment is complete? Do we just try to proceed with mint, and see if it works? Or is there a way to look up the paid status of a mintQuote?

Also, is there a way to let the client know, how many more confs are required, before the mint can take place?

Last question, what happens if the tx confirmation time exceeds the expiry?

17.md

callebtc · 2024-03-29T20:15:07Z

18.md

+The mint can return multiple `PostMeltQuoteBtcOnchainResponse` with different `fees` and `expiry` dates. The wallet can choose which one to pay and the other ones will expire.  Where `quote` is the quote ID, `amount` the amount that needs to be provided, and `fee` the additional fee that is required. The mint expects `Alice` to include `Proofs` of *at least* `total_amount = amount + fee`. `paid` indicates whether the request as been paid and `expiry` is the Unix timestamp until which the melt quote is valid.
+


I think it's worth mentioning that there are (at least) two ways of handing the variable fee rate problem here.

One option could be that the wallet chooses a fee in PostMeltQuoteBtcOnchainRequest this would be a bit like a Lightning node choosing the max_fee for a payment. The mint could then respond with a response or an error depending on whether it agrees. I think this would have to accompanied with some info setting where the mint announces it's accepted fee range.

The other option, as you've proposed, would be for the mint to limit the users's choices by returning multiple melt quotes.

Did you consider the first option as well? I wonder if it has any benefits. Happy to hear thoughts from others on this as well.

Interesting idea. No haven't thought about it yet.

callebtc · 2024-03-29T20:45:13Z

How do we know when the payment is complete? Do we just try to proceed with mint, and see if it works? Or is there a way to look up the paid status of a mintQuote?

You can use the following endpoint as per 17.md:

GET https://mint.host:3338/v1/mint/quote/btconchain/{quote_id}

Also, is there a way to let the client know, how many more confs are required, before the mint can take place?

This would be cool but I suspect it won't be generally possible to determine this number with every on-chain backend. Take for example a service like Strike or Blink. Obviously, this would be possible with a bitcoin core, lnd, cln, ... on-chain wallet.

what happens if the tx confirmation time exceeds the expiry?

That's a very good question. While LN invoices can have a clear expiry, on-chain is a bit more tricky. It might be worth to consider removing this from onchain mints. I think melt expiry doesn't have this problem.

callebtc · 2024-03-29T21:44:38Z

17.md

+  "quote": <str>,
+  "address": <str>,
+  "paid": <bool>,
+  "expiry": <int>


This expiry field might be problematic (cf @gandlafbtc's comment).

callebtc · 2024-03-29T21:45:14Z

Awesome NUT, feels complete! Looking forward to implementing it.

Left a few comments, I don't see any issues other than the expiry field for minting.

Co-authored-by: callebtc <[email protected]>

18.md

Co-authored-by: thesimplekid <[email protected]>

ngutech21 · 2024-03-31T11:11:22Z

what happens if the tx confirmation time exceeds the expiry?

That's a very good question. While LN invoices can have a clear expiry, on-chain is a bit more tricky. It might be worth to consider removing this from onchain mints. I think melt expiry doesn't have this problem.

Good point. I think it's problematic in both way: A wallet could choose a fee that is to low to get in the next block before the quote expires.
On the other side it might be problematic to have a quote that never expires. The way I see a quote is an offer or a contract between the mint and the wallet. If the quote would never expire, the offer is still valid and it would not be possible for a mint to switch to a different onchain backend. I know this is a very rare case. Maybe it would be a good idea to make the expiry optional and recommend a long expiry like 14 days as default for the mint. Any other suggestions?

thesimplekid · 2024-03-31T11:56:01Z

Maybe it would be a good idea to make the expiry optional and recommend a long expiry like 14 days as default for the mint.

Worth noting that for sat denominated quotes a long expiry is fine, but for units with an exchange rate (ie sat/usd) it introduces some risk to the mint where wallets could attempt to arbitrage the exchange rate since its up to them to execute the quote or not so i don't think long expiry times should be recommended for non sat units.

EDIT: Is this NUT limited to only the sat unit like NUT04? if so the above can be ignored.

17.md

18.md

17.md

elnosh · 2024-06-07T16:17:08Z

18.md

+GET https://mint.host:3338/v1/melt/btconchain/{tx_id}
+```
+
+The mint `Bob` responds with a `GetMeltBtcOnchainResponse`.
+
+```json
+{
+  "paid": false
+}
+```


is this paid field different than calling GET /v1/melt/quote/btconchain/{quote_id} and getting that paid status there?

I think this should be removed. I don't see any benefit over just using GET /v1/melt/quote/btconchain/{quote_id}.

A related open question I have is should the mint broadcast the transaction as soon as it receives valid proofs for the melt, or can the mint decide to wait and include it in a batch of multiple melts?

I think this should be removed. I don't see any benefit over just using GET /v1/melt/quote/btconchain/{quote_id}.

yeah

A related open question I have is should the mint broadcast the transaction as soon as it receives valid proofs for the melt, or can the mint decide to wait and include it in a batch of multiple melts?

interesting. That will require some changes to the response of the quote state call

I removed the redundant GET https://mint.host:3338/v1/melt/btconchain/{tx_id} endpoint

I think this should be removed. I don't see any benefit over just using GET /v1/melt/quote/btconchain/{quote_id}.

A related open question I have is should the mint broadcast the transaction as soon as it receives valid proofs for the melt, or can the mint decide to wait and include it in a batch of multiple melts?

IMO the mint can decide if it wants to batch transaction or not. This is same as centralized btc exchanges handle this. We could add a property to the info-endpoint to signal that a mint might delay the melt for batching, but I don't think this is necessary

IMO the mint can decide if it wants to batch transaction or not. This is same as centralized btc exchanges handle this. We could add a property to the info-endpoint to signal that a mint might delay the melt for batching, but I don't think this is necessary

I think we do need to signal this and it needs to be more concrete then the mint may delay. I would suggest we add a time component to the MeltQuoteResponse this way if the user wants the withdrawal more quickly they will need to pay a higher fee if they are willing to wait and allow the mint to batch they can select a Quote with a lower fee and wait longer.

Allowing the mint to delay for batching but not defining what a delay means will lead to a bad user experience where they don't know when their transaction will be process and they may need it immediately and be willing to pay for that.

Co-authored-by: thesimplekid <[email protected]>

18.md

EthnTuttle · 2024-06-26T01:28:35Z

No idea if this is relevant but was reviewing it and thought of this thread/PR/NUT.

The deposit flow in fedimint places the responsibility on the client to prove that a deposit is spendable by the mint. The client achieves this by generating a tweak applied to the mint's peg-in descriptor and sends funds to the tweaked address. Once the client observes enough confirmations, it will prove to the mint that the coins are spendable with the tweak and the merkle proof that the tx was included in a block. If the proof is valid, the mint will issue ecash for the deposit. With this flow, the mint won't be able to correlate user deposit activity if a new deposit address is used.
fedimint/fedimint#5473 (comment)

thesimplekid · 2024-06-27T22:58:12Z

17.md

+```json
+{
+  "amount": <int>,
+  "unit": <str_enum["sat"]>


Suggested change

"unit": <str_enum["sat"]>

Note: All PostMintQuoteBtcOnchainRequest's are denominated in sat.

Why should we remove the unit-field from the PostMintQuoteOnchainRequest? If the mint uses blink as a backend for handling the onchain transactions it can support onchain snd/receive with usd as a currency. Hopefully in the future there will be similar services. https://dev.blink.sv/api/usd-onchain-send

This is a question of scoping this NUT. To support other units where a conversion rate is involved how expiration is handled as well as how confirmation time is defined is much more important as the conversion rate could change outside an acceptable slippage. So in order to support other units how confirmation and expiration is defined needs to be included as well.

17.md

18.md

ngutech21 · 2024-07-28T13:56:40Z

what happens if the tx confirmation time exceeds the expiry?

That's a very good question. While LN invoices can have a clear expiry, on-chain is a bit more tricky. It might be worth to consider removing this from onchain mints. I think melt expiry doesn't have this problem.

Good point. I think it's problematic in both way: A wallet could choose a fee that is to low to get in the next block before the quote expires. On the other side it might be problematic to have a quote that never expires. The way I see a quote is an offer or a contract between the mint and the wallet. If the quote would never expire, the offer is still valid and it would not be possible for a mint to switch to a different onchain backend. I know this is a very rare case. Maybe it would be a good idea to make the expiry optional and recommend a long expiry like 14 days as default for the mint. Any other suggestions?

So what should we do? I think it would be best to change the expiry for mint-requests to optional so a mint can use a expiry for usd based mints and no expiry for sat based mint requests? Any other suggestions @gandlafbtc @callebtc @thesimplekid

Co-authored-by: thesimplekid <[email protected]>

thesimplekid · 2024-07-29T02:08:55Z

The issue with on chain is there is no way to expire an address unlike ln, so how is a deposit after an expiration handled is it considered a donation to the mint? If that is that case I think that needs to be made explicit. I think this maybe okay since even in the case of removing expiration that is effectively the case if a deposit is made to a mint that is no longer in operation (if the mint operator still has the keys), so having the explicit handling of expiration might be an improvement.

Of course there is the opportunity for a benevolent mint operator to settle a quote paid after out of band if they are known or have contact info set in the NUT-06. I noticed this is how the strike api handles it, though that has its own trade offs.

As i mentioned above definition of confirmation needs to be included as well with the expiration to signal what needs to happen before the expiration in order for the quote to be settled, num blocks conf, transaction broadcast. This could even be split for example transaction needs to be broadcast before x time to get the exchange rate, but ecash wont be issued until x confirmations.

ngutech21 · 2024-07-29T08:02:14Z

should there be a way for mints to charge a fee upfront in a mint quote request?

How do we know when the payment is complete? Do we just try to proceed with mint, and see if it works? Or is there a way to look up the paid status of a mintQuote?
Also, is there a way to let the client know, how many more confs are required, before the mint can take place?

regarding these questions, would it help or are there any concerns if the mint responded with the number of confirmations it requires to consider the mint quote paid?

Yes, good point. I have added min_confirmations to the info-endpoint

davidcaseria · 2024-08-08T15:28:17Z

18.md

+  "address": "bc1qkyfgd7mus7ykfd7qkwakq75qsf7rtm...",
+  "state": "UNPAID",
+  "expiry": 1701704757
+}


Is it worth adding the txid here?

It might though this question made me think what if a a quote is payed with multiple transaction, I think that should still be valid? So to cover that it would need to be a list of txid? Unless we explicitly say it MUST be paid in one tx.

thesimplekid · 2024-08-09T13:52:33Z

18.md

+```
+
+The wallet **MUST** store the `amount` in the request and the `quote` id in the response in its database so it can later request the tokens after paying the request. After payment, the wallet continues with the next section.
+


I think it would be worth adding a note here that wallets SHOULD display the quote as a BIP21 URI or BIP21 URI encoded as a QR code to the user. This would help reduce errors of underpaying or overpaying accidentally.

NOTE: There is a draft to replace BIP21 bitcoin/bips#1555 but as its backwards compatible i suggest we say bip21 for now and can update later.

prusnak · 2024-08-19T09:13:07Z

I wonder if we want to allow minting/melting on Liquid chain and if yes, then whether it should be part of these two nuts or a new pair of nuts.

davidcaseria · 2024-08-24T10:47:57Z

I wonder if we want to allow minting/melting on Liquid chain and if yes, then whether it should be part of these two nuts or a new pair of nuts.

I think it makes more sense to keep separate NUTS, especially since its support should be signaled differently by NUT-06.

prusnak · 2024-08-24T13:05:16Z

especially since its support should be signaled differently by NUT-06.

Ah yes, that is indeed a good reason.

davidcaseria · 2024-08-30T13:23:35Z

It does not necessarily impact the spec, but something like this should be the recommended way to handle address generation: https://blog.zaprite.com/optimizing-address-usage-for-the-gap-limit/

thesimplekid · 2024-09-05T18:02:18Z

19.md

+```json
+[
+  {
+   "quote": <str>,
+   "description": <str|null>,
+   "amount": <int>,
+   "fee": <int>,
+   "state": <str_enum[STATE]>,
+   "expiry": <int>
+  }
+]
+```
+The mint can return multiple `PostMeltQuoteBtcOnchainResponse` with different `fees` and `expiry` dates. The wallet can choose which one to pay and the other ones will expire.  Where `quote` is the quote ID, `amount` the amount that needs to be provided, and `fee` the additional fee that is required. The mint expects `Alice` to include `Proofs` of *at least* `total_amount = amount + fee`. `paid` indicates whether the request as been paid and `expiry` is the Unix timestamp until which the melt quote is valid.


It maybe better if we express fee in sats but also with a time component. This would allow the mint to batch transactions. For example fee of x sats will be paid within the hour, fee of y sats within the day etc. This leaves it up to the mint to actually set the final sats per vbyte to meet whatever time period they agreed to in the quote.

thesimplekid · 2024-09-05T18:07:05Z

18.md

+```json
+{
+  "amount": <int>,
+  "unit": <str_enum["sat"]>
+}
+```
+ with the requested `amount` and the `unit`. 
+
+ The mint `Bob` then responds with a `PostMintQuoteBtcOnchainResponse`:
+
+```json
+{
+  "quote": <str>,
+  "address": <str>,
+  "state": <str_enum[STATE]>,
+  "expiry": <int>
+}
+```


If unit is included here don't we need to add an amount in sats to the quote response so the mint can signal the exchange rate. Otherwise if it is non bitcoin unit the wallet will not know how much bitcoin to send to the address to fill the quote.

That being said because of the imprecise nature of sending a bitcoin onchain transaction I would be for removing the unit and limiting it to sat denominated quotes.

add specs for minting and melting tokens onchain

cc4da36

callebtc reviewed Mar 29, 2024

View reviewed changes

17.md Outdated Show resolved Hide resolved

callebtc reviewed Mar 29, 2024

View reviewed changes

17.md Outdated Show resolved Hide resolved

callebtc reviewed Mar 29, 2024

View reviewed changes

callebtc mentioned this pull request Mar 29, 2024

NUT-XX: Multinut payments #103

Merged

callebtc reviewed Mar 29, 2024

View reviewed changes

ngutech21 and others added 2 commits March 30, 2024 09:25

chore: rename payment_method to method

5a1edde

Co-authored-by: callebtc <[email protected]>

chore: increase min_amount

2290606

Co-authored-by: callebtc <[email protected]>

thesimplekid reviewed Mar 30, 2024

View reviewed changes

18.md Outdated Show resolved Hide resolved

chore: rename payment_method

b4dc153

Co-authored-by: thesimplekid <[email protected]>

thesimplekid reviewed Mar 31, 2024

View reviewed changes

17.md Outdated Show resolved Hide resolved

18.md Outdated Show resolved Hide resolved

thesimplekid reviewed Mar 31, 2024

View reviewed changes

18.md Outdated Show resolved Hide resolved

thesimplekid reviewed Mar 31, 2024

View reviewed changes

18.md Outdated Show resolved Hide resolved

thesimplekid mentioned this pull request Mar 31, 2024

feat(cashuNUT17NUT18): btc onchain structs cashubtc/cdk#66

Closed

callebtc added the new nut A new protocol NUT label May 11, 2024

thesimplekid reviewed May 31, 2024

View reviewed changes

17.md Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

elnosh reviewed Jun 7, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

ngutech21 and others added 2 commits June 18, 2024 15:38

fix: typo in settings

91f051f

Co-authored-by: thesimplekid <[email protected]>

fix: txid is optional

46f9867

Co-authored-by: thesimplekid <[email protected]>

callebtc changed the title ~~NUT-17 and NUT-18: Mint / Melt Bitcoin On-Chain~~ NUT-XX and NUT-XX+1: Mint / Melt Bitcoin On-Chain Jun 18, 2024

thesimplekid reviewed Jun 24, 2024

View reviewed changes

18.md Outdated Show resolved Hide resolved

thesimplekid requested changes Jun 27, 2024

View reviewed changes

chore: OnchainQuoteReponse.description is optional

bba6d32

ngutech21 and others added 5 commits July 28, 2024 16:17

chore: use state enum instead of bool

1aaf174

Co-authored-by: thesimplekid <[email protected]>

chore: cleanup examples

2e73249

chore: use state enum instead of paid flag

7b54066

Co-authored-by: thesimplekid <[email protected]>

chore: cleaup examples

93a57f0

chore: rename nuts

03f4d5c

ngutech21 marked this pull request as ready for review July 28, 2024 14:48

ngutech21 added 3 commits July 29, 2024 09:45

chore: merge 'origin/main' into mint-melt-onchain

d671cdf

chore: add nut-18 and nut-19 to readme

f48d97a

feat: add min-confirmations to info-endpoint

f2d660d

ngutech21 added 2 commits July 29, 2024 10:10

fix: formatting

94c139c

chore: remove check tx-status

27a8e38

davidcaseria reviewed Aug 8, 2024

View reviewed changes

thesimplekid reviewed Aug 9, 2024

View reviewed changes

prusnak mentioned this pull request Aug 21, 2024

feat: btc on chain cashubtc/cdk#172

Draft

thesimplekid reviewed Sep 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NUT-XX and NUT-XX+1: Mint / Melt Bitcoin On-Chain #107

NUT-XX and NUT-XX+1: Mint / Melt Bitcoin On-Chain #107

ngutech21 commented Mar 29, 2024

gandlafbtc commented Mar 29, 2024

callebtc Mar 29, 2024 •

edited

Loading

ngutech21 Mar 31, 2024

callebtc commented Mar 29, 2024

callebtc Mar 29, 2024

callebtc commented Mar 29, 2024 •

edited

Loading

ngutech21 commented Mar 31, 2024

thesimplekid commented Mar 31, 2024 •

edited

Loading

This comment was marked as resolved.

elnosh Jun 7, 2024

thesimplekid Jun 7, 2024

elnosh Jun 8, 2024

ngutech21 Jul 29, 2024

ngutech21 Aug 1, 2024

thesimplekid Aug 1, 2024

This comment was marked as resolved.

EthnTuttle commented Jun 26, 2024

thesimplekid Jun 27, 2024

ngutech21 Jul 28, 2024

thesimplekid Jul 29, 2024

ngutech21 commented Jul 28, 2024

thesimplekid commented Jul 29, 2024

ngutech21 commented Jul 29, 2024

davidcaseria Aug 8, 2024

thesimplekid Aug 9, 2024

thesimplekid Aug 9, 2024

prusnak commented Aug 19, 2024 •

edited

Loading

davidcaseria commented Aug 24, 2024

prusnak commented Aug 24, 2024

davidcaseria commented Aug 30, 2024

thesimplekid Sep 5, 2024 •

edited

Loading

thesimplekid Sep 5, 2024 •

edited

Loading

		The mint can return multiple `PostMeltQuoteBtcOnchainResponse` with different `fees` and `expiry` dates. The wallet can choose which one to pay and the other ones will expire. Where `quote` is the quote ID, `amount` the amount that needs to be provided, and `fee` the additional fee that is required. The mint expects `Alice` to include `Proofs` of at least `total_amount = amount + fee`. `paid` indicates whether the request as been paid and `expiry` is the Unix timestamp until which the melt quote is valid.

		```

		The wallet MUST store the `amount` in the request and the `quote` id in the response in its database so it can later request the tokens after paying the request. After payment, the wallet continues with the next section.

NUT-XX and NUT-XX+1: Mint / Melt Bitcoin On-Chain #107

Are you sure you want to change the base?

NUT-XX and NUT-XX+1: Mint / Melt Bitcoin On-Chain #107

Conversation

ngutech21 commented Mar 29, 2024

gandlafbtc commented Mar 29, 2024

callebtc Mar 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

callebtc commented Mar 29, 2024

Choose a reason for hiding this comment

callebtc commented Mar 29, 2024 • edited Loading

ngutech21 commented Mar 31, 2024

thesimplekid commented Mar 31, 2024 • edited Loading

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

EthnTuttle commented Jun 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngutech21 commented Jul 28, 2024

thesimplekid commented Jul 29, 2024

ngutech21 commented Jul 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prusnak commented Aug 19, 2024 • edited Loading

davidcaseria commented Aug 24, 2024

prusnak commented Aug 24, 2024

davidcaseria commented Aug 30, 2024

thesimplekid Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

thesimplekid Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

callebtc Mar 29, 2024 •

edited

Loading

callebtc commented Mar 29, 2024 •

edited

Loading

thesimplekid commented Mar 31, 2024 •

edited

Loading

prusnak commented Aug 19, 2024 •

edited

Loading

thesimplekid Sep 5, 2024 •

edited

Loading

thesimplekid Sep 5, 2024 •

edited

Loading