NUT-06: Add "MINT_ICON_URL" Field for Mint Profile Images #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe another feasible way to serve icons would be as base64 encoded webp ("MINT_ICON_B64"). This is the way Robosats currently implements icons in the frontend: There is also a script to generate the webp icons here: |
callebtc
reviewed
Jul 26, 2024
|
implemented in CDK cashubtc/cdk#282 |
|
To avoid making this a breaking change we should note that this is an optional field that may not be included. |
Their naming conventions prefix all fields with |
callebtc
changed the title
prusnak
reviewed
Aug 29, 2024
| @@ -39,6 +39,7 @@ With the mint's response being of the form `GetInfoResponse`: | |||
| } | |||
| ], | |||
| "motd": "Message to display to users.", | |||
| "mint_icon_url": "https://mint.host/icon.jpg", | |||
There was a problem hiding this comment.
Suggested change
| "mint_icon_url": "https://mint.host/icon.jpg", | |
| "icon_url": "https://mint.host/icon.jpg", |
| @@ -88,6 +89,7 @@ With the mint's response being of the form `GetInfoResponse`: | |||
| - `description_long` is a long description that can be shown in an additional field. | |||
| - `contact` is an array of contact objects to reach the mint operator. A contact object consists of two fields. The `method` field denotes the contact method (like "email"), the `info` field denotes the identifier (like "[email protected]"). | |||
| - `modt` is the message of the day that the wallet must display to the user. It should only be used to display important announcements to users, such as scheduled maintenances. | |||
| - `mint_icon_url` is the URL pointing to an image to be used as an icon for the mint. Recommended to be squared in shape. | |||
There was a problem hiding this comment.
Suggested change
| - `mint_icon_url` is the URL pointing to an image to be used as an icon for the mint. Recommended to be squared in shape. | |
| - (optional) `icon_url` is the URL pointing to an image to be used as an icon for the mint. Recommended to be squared in shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to add a
mint_icon_urlfield to allow mint operators to include a profile image. This feature enables applications to index and display the image, making it easier for users to identify the mint.The Fedimint protocol provides a similar feature with the
federation_icon_url.Following their naming convention, I proposemint_icon_urlas the metadata field.Below is a visual example of how an app might index and display the mint metadata fields. The profile icon can be a useful addition to the existing options.
