-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NUT-04: add new state
enum, deprecate paid
#141
Conversation
when would a quote be in a |
When it's currently being issued (i.e. in a mint transaction). The pending state can be used by the mint to prevent race conditions. |
Implemented in Nutmix |
Pending state removed in 9e86b9e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9e86b9e
LFG |
What
This change to NUT-04 deprecates the
paid
field toPostMintQuoteBolt11Response
and replaces it with a newstate
field that is a string enum with four possible values:UNPAID
,PAID
, andISSUED
."UNPAID"
means that the quote's request has not been paid yet."PAID"
means that the request has been paid."ISSUED"
means that the quote has already been issued.Implementation
Mints
state
field toPostMintQuoteBolt11Response
paid
field around until all wallets updateWallets
paid
field withstate
As long as
paid
is kept around, wallets can still function the same way as before, also when thePOST /v1/mint/bolt11
is changed (since JSON is "backwards compatible" to new fields).Tracking progress: