Remove [ThreadStatic] from MetaTypeElementUtil

castleproject · Jul 6, 2017 · 01d4085 · 01d4085
1 parent b3ea5a3
commit 01d4085
Showing 1 changed file with 10 additions and 13 deletions.
diff --git a/src/Castle.Core/DynamicProxy/Generators/MetaTypeElementUtil.cs b/src/Castle.Core/DynamicProxy/Generators/MetaTypeElementUtil.cs
@@ -20,23 +20,20 @@ namespace Castle.DynamicProxy.Generators
 
 	internal static class MetaTypeElementUtil
     {
-		[ThreadStatic]
-		private static StringBuilder sharedNameBuilder;
-
 		public static string CreateNameForExplicitImplementation(Type sourceType, string name)
 		{
-			if (sharedNameBuilder == null)
+			if (sourceType.GetTypeInfo().IsGenericType)
 			{
-				sharedNameBuilder = new StringBuilder();
+				var nameBuilder = new StringBuilder();
+				nameBuilder.AppendNameOf(sourceType);
+				nameBuilder.Append('.');
+				nameBuilder.Append(name);
+				return nameBuilder.ToString();
+			}
+			else
+			{
+				return string.Concat(sourceType.Name, ".", name);
 			}
-
-			var nameBuilder = sharedNameBuilder;
-			nameBuilder.Length = 0;
-			nameBuilder.AppendNameOf(sourceType);
-			nameBuilder.Append('.');
-			nameBuilder.Append(name);
-
-			return nameBuilder.ToString();
 		}
 
 		private static void AppendNameOf(this StringBuilder nameBuilder, Type type)