Upgrade to Lucene 9.8.0 #2226
Merged
Upgrade to Lucene 9.8.0 #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lintool
reviewed
Oct 24, 2023
lintool
approved these changes
Oct 24, 2023
|
Let's go ahead and merge! (And I'll run all our regressions from scratch anyway...) |
jpountz
reviewed
Oct 24, 2023
| @@ -78,7 +78,7 @@ public static void main(String[] args) throws Exception { | |||
|
|
|||
| out.println("internal_docid\texternal_docid\tdoc_length\tunique_term_count\tlossy_doc_length\tlossy_unique_term_count"); | |||
| for (int i = 0; i < numDocs; i++) { | |||
| Terms terms = reader.getTermVector(i, Constants.CONTENTS); | |||
| Terms terms = reader.termVectors().get(i, Constants.CONTENTS); | |||
There was a problem hiding this comment.
Ideally you'd fetch the reader.termVectors() object only once, before the loop, and then reuse it in the loop. (And similarly to other places that rely on stored fields and term vectors.)
There was a problem hiding this comment.
yeah, good point!
There was a problem hiding this comment.
Will have another PR fix that in different places (and perhaps storedFields() too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Anserini to use Apache Lucene 9.8.0.