Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring on the Anserini end to enable cleaner Pyserini bindings #2584

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

lintool
Copy link
Member

@lintool lintool commented Aug 31, 2024

@lintool lintool marked this pull request as draft August 31, 2024 17:20
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 68.62745% with 32 lines in your changes missing coverage. Please review.

Project coverage is 67.17%. Comparing base (9744463) to head (43be5d7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/anserini/search/FlatDenseSearcher.java 65.51% 7 Missing and 3 partials ⚠️
...ain/java/io/anserini/search/HnswDenseSearcher.java 65.51% 7 Missing and 3 partials ⚠️
...java/io/anserini/search/InvertedDenseSearcher.java 62.50% 6 Missing and 3 partials ⚠️
...ava/io/anserini/search/SearchFlatDenseVectors.java 87.50% 1 Missing ⚠️
...ava/io/anserini/search/SearchHnswDenseVectors.java 87.50% 1 Missing ⚠️
...io/anserini/search/SearchInvertedDenseVectors.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2584      +/-   ##
============================================
- Coverage     67.18%   67.17%   -0.02%     
+ Complexity     1480     1479       -1     
============================================
  Files           219      219              
  Lines         12700    12700              
  Branches       1530     1530              
============================================
- Hits           8533     8531       -2     
- Misses         3640     3641       +1     
- Partials        527      528       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool
Copy link
Member Author

lintool commented Sep 4, 2024

@MXueguang this is ready for review. The code coverage check is pointing at lines that are difficult to test, so I'm going to punt on that now.

Running regressions - all seems good so far. Will circle back and confirm but CR can proceed in parallel.

@lintool lintool merged commit 05613e3 into master Sep 6, 2024
2 of 3 checks passed
@lintool lintool deleted the binding-tweaks branch September 6, 2024 16:54
lintool added a commit to castorini/pyserini that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants