Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Lucene 8 #702

Merged
merged 12 commits into from
Jun 12, 2019
Merged

Upgrade to Lucene 8 #702

merged 12 commits into from
Jun 12, 2019

Conversation

lintool
Copy link
Member

@lintool lintool commented Jun 12, 2019

Here it is... the upgrade to Lucene 8. Following regression tests pass:

[o] nohup python src/main/python/run_regression.py --collection disk12 >& log.disk12 &
[o] nohup python src/main/python/run_regression.py --collection robust04 >& log.robust04 &
[o] nohup python src/main/python/run_regression.py --collection robust05 >& log.robust05 &
[o] nohup python src/main/python/run_regression.py --collection core17 >& log.core17 &
[o] nohup python src/main/python/run_regression.py --collection core18 >& log.core18 &

[o] nohup python src/main/python/run_regression.py --collection mb11 >& log.mb11 &
[o] nohup python src/main/python/run_regression.py --collection mb13 >& log.mb13 &

[o] nohup python src/main/python/run_regression.py --collection wt10g >& log.wt10g &
[o] nohup python src/main/python/run_regression.py --collection gov2 >& log.gov2 &
[o] nohup python src/main/python/run_regression.py --collection cw09b >& log.cw09b &
[o] nohup python src/main/python/run_regression.py --collection cw12b13 >& log.cw12b13 &
[o] nohup python src/main/python/run_regression.py --collection cw12 >& log.cw12 &

[o] nohup python src/main/python/run_regression.py --collection car17v1.5 >& log.car17v1.5 &
[o] nohup python src/main/python/run_regression.py --collection car17v2.0 >& log.car17v2.0 &

[o] nohup python src/main/python/run_regression.py --collection msmarco-passage >& log.msmarco-passage &
[o] nohup python src/main/python/run_regression.py --collection msmarco-doc >& log.msmarco-doc &

Note: although there are lots of changes, all patches have already been reviewed before merge to the lucene8 branch, so it's not as big a code drop as it seems.

I will merge after getting 👍 - for this I plan on a merge commit, not a squash.

jpountz and others added 10 commits March 14, 2019 08:48
@jpountz
Upgrade to Lucene 8.
2a1585f
@jpountz
Use Lucene`s Axiomatic similarity.
3b44a7e
@lintool
Merge branch 'lucene8' of https://github.com/jpountz/Anserini into lu…
65d89e4 
…cene8
@lintool
Fixed all regressions for Lucene8 (#596)
813e592
@lintool
Merge branch 'master' into lucene8
14258a0 
Conflicts:
	docs/experiments-car17.md
	docs/experiments-core17.md
	docs/experiments-core18.md
	src/main/java/io/anserini/search/SearchCollection.java
	src/main/java/io/anserini/search/SimpleSearcher.java
	src/main/resources/regression/car17v1.5.yaml
	src/main/resources/regression/core17.yaml
	src/main/resources/regression/core18.yaml
@lintool
Fixed compiler error and regressions.
5b4c785
@lintool
Tweaks.
bebbda0
@lintool
merge v0.5.0 into lucene8 branch
d980585 
Fixed broken compile and regression numbers.
Note that this is a merge commit to explicitly preserve history.
@lintool
Merge branch 'master' into lucene8
5ffd79a
@lintool
Fixed broken regressions.
b485d23
@lintool lintool merged commit 75e36f9 into master Jun 12, 2019
@lintool lintool deleted the lucene8 branch June 12, 2019 19:41
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
@lintool
DeepImpact and uniCOIL reproduction; minor documentation tweaks (cast…
84fef46 
…orini#702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-clancy ryan-clancy ryan-clancy approved these changes

@rodrigonogueira4 rodrigonogueira4 rodrigonogueira4 approved these changes

@zeynepakkalyoncu zeynepakkalyoncu zeynepakkalyoncu approved these changes

@emmileaf emmileaf emmileaf approved these changes

@Victor0118 Victor0118 Awaiting requested review from Victor0118

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lintool @ryan-clancy @rodrigonogueira4 @zeynepakkalyoncu @emmileaf @jpountz