Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set more efficient default for mask type #531

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CodyCBakerPhD
Copy link
Member

With mask_type='image' a relatively big segmentation dataset took forever and worse, stalled out in unstoppable ways (unless you completely kill the process from outside)

But swapping to pixel worked instantaneously. Proposing to set it as the default for both speed and reduced memory usage

@bendichter
Copy link
Contributor

bendichter commented Aug 31, 2023

I suppose this is fine. Let's add an entry to the changelog though since this will change behavior for some users.

@CodyCBakerPhD
Copy link
Member Author

Actually it could be a breaking change now that I think about it

image always work, but is the most inefficient for a large number of ROIs and/or large image resolution

pixels only works for 2D (non volumetric) imaging, so though it's more efficient specifying it in this way would break all volumetric pipelines that don't already override the option

Maybe a better distinction for the argument could be full or sparse (with sparse auto-detecting pixel or voxel appropriately based on image dimensions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants