stub options #670
stub options #670
Conversation
|
Can you describe what you need this for? |
| def subset_recording(self, stub_test: bool = False): | ||
| def subset_recording(self, stub_test_size: int = None): |
There was a problem hiding this comment.
Breaks back-compatability; please add deprecation cycle to stub_test
| stub_test: bool = False, | ||
| stub_test_size: int = 100, |
There was a problem hiding this comment.
I would also recommend calling this stub_frames or anything else to indicate it is not stubbing channels along the way (I know it's in the docstring, but if it's in the variable name that's even clearer)
There was a problem hiding this comment.
We use this already, don't we?
neuroconv/src/neuroconv/datainterfaces/ophys/baseimagingextractorinterface.py
Lines 109 to 110 in 74689fd
| recording = self.subset_recording(stub_test=stub_test) | ||
| recording = self.subset_recording(stub_test_size=stub_test_size) |
There was a problem hiding this comment.
Same comment above; this would break all current scripts relying on stub_test as the syntax for testing conversions. Not to mention the GUIDE
|
hey @CodyCBakerPhD these are some changes I made locally to be able to create a converted file with a meaningful subset of the spikeglx recordings, I thought it could be useful in general |
Were you attempting to make the preview files longer or shorter than the previous default stubbing? Not against adding control to this in general, would just prefer it be done in a smooth way In general the hope was actually for stubbing to be a part of the general backend configuration mechanism but that particular aspect proves a little tricky ATM so a bit delayed on that front |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 92.20% 92.18% -0.02%
==========================================
Files 115 115
Lines 5964 5966 +2
==========================================
+ Hits 5499 5500 +1
- Misses 465 466 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
small modification which allows for changing the sample size of the sub recording conversion