Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try new structure for conversion examples #726

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Feb 7, 2024

The problem is that currently with the new pydata skin there are 3 different tables that basically do the same thing:

image

With this new navigation, it may be more convenient to put all the conversion examples on a single page, making it easier to CTRL+F. You can easily navigate to the desired conversion using the sidebar.

What do you guys think of this as an alternative structure/layout?

image

@bendichter
Copy link
Contributor Author

Here's another alternative:

image

@h-mayorquin
Copy link
Collaborator

h-mayorquin commented Feb 8, 2024

I think this is a good idea. We discussed something like this with the core-team If I remember well.

With the navigation tables I see no lost as the user can still go to the code they want directly while at the same time we keep the folder structure for test and code organization. The links to share a specific section seem to be working as well:

https://neuroconv--726.org.readthedocs.build/en/726/conversion_example_gallery.html#alphaomega

I prefer the current last version with all the navigation collapsed on the left. The version of this with two side bars (like Pandas) here works only when there is a deep structure which we don't have here.

I checked in mobile and it also seems to look OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants