Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable values specifiers for add_electrodes #985

Merged
merged 31 commits into from
Aug 13, 2024
Merged

Conversation

h-mayorquin
Copy link
Collaborator

Has #984 as base. This drops the int casting for the electrrodes table as discussed in #964.

The important thing is that it drops a bug where data is lost when converting int64 to float.

I will make a similar one for the units table.

@h-mayorquin h-mayorquin added the bug label Aug 6, 2024
@h-mayorquin h-mayorquin self-assigned this Aug 6, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review August 8, 2024 13:35
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (fc6ae26) to head (34870ff).
Report is 2 commits behind head on main.

Files Patch % Lines
...c/neuroconv/tools/spikeinterface/spikeinterface.py 95.45% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   90.63%   91.43%   +0.80%     
==========================================
  Files         127      127              
  Lines        7525     7540      +15     
==========================================
+ Hits         6820     6894      +74     
+ Misses        705      646      -59     
Flag Coverage Δ
unittests 91.43% <95.45%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/neuroconv/tools/spikeinterface/spikeinterface.py 95.12% <95.45%> (+11.99%) ⬆️

@CodyCBakerPhD CodyCBakerPhD merged commit b9507bf into main Aug 13, 2024
34 of 35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the drop_for_good branch August 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants