-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Bruker converters add_to_nwb
and run_conversion
consistent with all the other converters
#987
base: main
Are you sure you want to change the base?
Conversation
…ub.com/catalystneuro/neuroconv into second_fix_converter_in_converter_stub
I'll let @weiglszonja chime in with their thoughts since this style came up with most of their subconverters |
This is not going to be good for converters that a lot of interfaces (altought I think that should not happen) so we should provide some utility function for that. |
Can you elaborate this? I'm not sure I understand the issue enough here |
Converters core methods
add_to_nwb
should be consistent. This PR deprecates the kwargs mechanism of the bruker converters and substitutes it for passing a dictionary as in all the other cases.This will avoid the need to do introspection in #979