-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor nwb extractor frames and tests #136
Conversation
This is the PR in |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 66.38% 68.06% +1.67%
==========================================
Files 31 31
Lines 1919 1926 +7
==========================================
+ Hits 1274 1311 +37
+ Misses 645 615 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@CodyCBakerPhD Also, I realized that most of the other |
This is the first attempt at getting correct frames in
nwb_extractor
. This branch should be tested innwb-conversion-tools
to see if everything works as we expected over there. I refactored the function and added a test to see that it works as expected.I intend to add a test to support loading
TwoPhotonTimeSeries
with channels but that's not the priority right now.