-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moves, fix RDM quests, add .gitignore #7
Conversation
.gitignore
Outdated
cogs/__pycache__/ | ||
config/ | ||
data/raid_cache.json | ||
util/__pycache__/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can replace lines 1,2, & 5 with:
**/__pycache__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted and will show on next push. Working on something with Andi before pushing again, explanation on push comment. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things I've noticed
cogs/boards.py
Outdated
@@ -123,10 +123,15 @@ async def board_loop(self): | |||
if "mon_today" in board['type']: | |||
mon_today = await queries.statboard_mon_today(self.bot.config, area[0]) | |||
if "mon_active" in board['type']: | |||
text = f"{text}{self.bot.custom_emotes['pokeball']} **{mon_active[0][0]:,}** {self.bot.locale['active_pokemon']} | **{mon_today[0][0]:,}** {self.bot.locale['today']}\n\n" | |||
scanned_ratio = int(round((mon_today[0][1] / mon_today[0][0] * 100), 0)) | |||
text = f"{text}{self.bot.custom_emotes['pokeball']} **{mon_active[0][0]:,}** {self.bot.locale['active_pokemon']} | **{mon_today[0][0]:,}** ({scanned_ratio}% mit IVs) {self.bot.locale['today']}\n\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This needs translations for "mit" ("with" in English)
- If you're implementing it for mon_today, then it should also show for mon_active and mon_today without mon_active enabled
- Querying for mons with IVs takes ages in my big mon table. The Pokemon query itself already eats my CPU, this might be too much now. This should be an extra option
cogs/boards.py
Outdated
|
||
|
||
if "hundos_today" in board['type']: | ||
hundos_today = await queries.statboard_hundos_today(self.bot.config, area[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Hundos will also take ages for larger tables
- You should implement this in the
!board create
command, so you can choose this option when using the command - Again, this needs better translations (=an extra string in the locale files)
- Maybe also add hundo_active while you're at it?
@@ -1773,7 +1773,7 @@ | |||
"damage": 16, | |||
"duration": 1200, | |||
"energy": 8, | |||
"dps": 13.33 | |||
"dps": 13.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you update this move file, please also do the French and German one. Else, setups in those langs will break
Andi left me waiting for some more code :) as for the translations, I was hoping ppl who use those would do that LOL PMSF only had english and then a list of converted names in the locale files. I suppose while I'm waiting I could use those locale files and do them though. Stat board got some love :) |
Using PMSF Develop as source DE - translated to 320 "Charm" - no more moves were in the list, english in there |
I'm testing this PR right now and I have some thoughts about translations:
These 2 could be just boards exclusive so that would make more sense with all translations ;) Oh and great job btw :D I love this PR |
Tested and working per screenshots. Thanks to Andi#0129 for the RDM fixes. Someone will need to add the new data to the move translation files, I used PMSF & they have a different translation system, and Poracles aren't updated.
![test1](https://user-images.githubusercontent.com/10344114/80836957-d49a7f80-8bc3-11ea-8143-2a9ab5e83a44.png)
![test2](https://user-images.githubusercontent.com/10344114/80836958-d5331600-8bc3-11ea-8fd5-89e92823fe24.png)
![test3](https://user-images.githubusercontent.com/10344114/80836960-d5331600-8bc3-11ea-9e53-3ec83978cfeb.png)