Update moves, fix RDM quests, add .gitignore #7
Conversation
.gitignore
Outdated
| cogs/__pycache__/ | ||
| config/ | ||
| data/raid_cache.json | ||
| util/__pycache__/ |
There was a problem hiding this comment.
You can replace lines 1,2, & 5 with:
**/__pycache__
There was a problem hiding this comment.
Adjusted and will show on next push. Working on something with Andi before pushing again, explanation on push comment. Thanks!
cogs/boards.py
Outdated
| @@ -123,10 +123,15 @@ async def board_loop(self): | |||
| if "mon_today" in board['type']: | |||
| mon_today = await queries.statboard_mon_today(self.bot.config, area[0]) | |||
| if "mon_active" in board['type']: | |||
| text = f"{text}{self.bot.custom_emotes['pokeball']} **{mon_active[0][0]:,}** {self.bot.locale['active_pokemon']} | **{mon_today[0][0]:,}** {self.bot.locale['today']}\n\n" | |||
| scanned_ratio = int(round((mon_today[0][1] / mon_today[0][0] * 100), 0)) | |||
| text = f"{text}{self.bot.custom_emotes['pokeball']} **{mon_active[0][0]:,}** {self.bot.locale['active_pokemon']} | **{mon_today[0][0]:,}** ({scanned_ratio}% mit IVs) {self.bot.locale['today']}\n\n" | |||
There was a problem hiding this comment.
- This needs translations for "mit" ("with" in English)
- If you're implementing it for mon_today, then it should also show for mon_active and mon_today without mon_active enabled
- Querying for mons with IVs takes ages in my big mon table. The Pokemon query itself already eats my CPU, this might be too much now. This should be an extra option
cogs/boards.py
Outdated
|
|
||
|
|
||
| if "hundos_today" in board['type']: | ||
| hundos_today = await queries.statboard_hundos_today(self.bot.config, area[0]) |
There was a problem hiding this comment.
- Hundos will also take ages for larger tables
- You should implement this in the
!board createcommand, so you can choose this option when using the command - Again, this needs better translations (=an extra string in the locale files)
- Maybe also add hundo_active while you're at it?
| @@ -1773,7 +1773,7 @@ | |||
| "damage": 16, | |||
| "duration": 1200, | |||
| "energy": 8, | |||
| "dps": 13.33 | |||
| "dps": 13.3 | |||
There was a problem hiding this comment.
If you update this move file, please also do the French and German one. Else, setups in those langs will break
|
Andi left me waiting for some more code :) as for the translations, I was hoping ppl who use those would do that LOL PMSF only had english and then a list of converted names in the locale files. I suppose while I'm waiting I could use those locale files and do them though. Stat board got some love :) |
|
Using PMSF Develop as source DE - translated to 320 "Charm" - no more moves were in the list, english in there |
|
Along with the above corrections, several options for the stats board have been added, debugged and tested. New options: cmd json raid level [all,1,2,3,4 or 5] "raid_lvl*_active" total active raids of each level.
|
|
I'm testing this PR right now and I have some thoughts about translations:
These 2 could be just boards exclusive so that would make more sense with all translations ;) Oh and great job btw :D I love this PR |
Tested and working per screenshots. Thanks to Andi#0129 for the RDM fixes. Someone will need to add the new data to the move translation files, I used PMSF & they have a different translation system, and Poracles aren't updated.
