Introduce input sort #183

hibenj · 2023-04-14T09:07:39Z

Description

Network_ordering utilizes following files:

(NEW_FILE)ortho_ordering_network.hpp: implementation of the algorithm
(NEW_FILE)inverter_balancing.hpp: given a fanout node with two inverters as fanouts, the inverters are replaced by one inverter at the fanout-node's input
(NEW_FILE)input_ordering_view.hpp: orders the inputs of a network (taking into account the connection between PIs)
network_blueprints: included some test_cases relevant for the ordering_network

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

codecov · 2023-04-14T15:52:56Z

Codecov Report

Merging #183 (eed2c32) into main (bfee388) will decrease coverage by 0.30%.
The diff coverage is 94.21%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   94.55%   94.25%   -0.30%     
==========================================
  Files          83       87       +4     
  Lines        7581     8183     +602     
==========================================
+ Hits         7168     7713     +545     
- Misses        413      470      +57

Impacted Files	Coverage Δ
...orithms/physical_design/ortho_ordering_network.hpp	`92.64% <92.64%> (ø)`
...ude/fiction/networks/views/input_ordering_view.hpp	`95.65% <95.65%> (ø)`
...s/network_transformation/inverter_substitution.hpp	`96.51% <96.51%> (ø)`

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfee388...eed2c32. Read the comment docs.

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp

marcelwa

Many thanks for your effort with this contribution! Thus far, I have looked at the inverter balancing part in detail and had a quick look at the tests. Since my comments also point you toward more general topics that apply to all files, I would like to give you the opportunity to address them in all of your files, before I have a look at the remaining source code.

include/fiction/algorithms/network_transformation/inverter_balancing.hpp

into Introduce_Input_Sort

hibenj · 2023-04-20T12:11:50Z

GitHub told me that i have to fetch some differences and now there is also a commit in this branch called: [Merge branch 'Introduce_Input_Sort' of], where some changes from your repository (i think) are included. Maybe have a quick look at it if everything is fine there.

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp

…ven logic network

marcelwa · 2023-04-21T10:43:38Z

GitHub told me that i have to fetch some differences and now there is also a commit in this branch called: [Merge branch 'Introduce_Input_Sort' of], where some changes from your repository (i think) are included. Maybe have a quick look at it if everything is fine there.

That seems fine 👍

marcelwa

Many thanks for your adjustments. Looks a lot better already!

As before, let's iterate a few files in detail while you can apply the lessons learned to the others as well.

cli/cmd/logic/inverterbalance.hpp

include/fiction/algorithms/network_transformation/inverter_balancing.hpp

codecov · 2023-11-21T08:45:55Z

Codecov Report

Merging #183 (a2edcc4) into main (07d5712) will decrease coverage by 0.17%.
Report is 5 commits behind head on main.
The diff coverage is 97.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   96.04%   95.87%   -0.17%     
==========================================
  Files         102      106       +4     
  Lines       10101    10720     +619     
==========================================
+ Hits         9701    10278     +577     
- Misses        400      442      +42

Files	Coverage Δ
...ude/fiction/networks/views/input_ordering_view.hpp	`99.40% <99.40%> (ø)`
...s/network_transformation/inverter_substitution.hpp	`92.85% <92.85%> (ø)`
...orithms/physical_design/ortho_ordering_network.hpp	`97.04% <97.04%> (ø)`

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c66aa4...a2edcc4. Read the comment docs.

github-actions

clang-tidy made some suggestions

experiments/DN_experiments/DN_experiments.cpp

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp

github-actions

clang-tidy made some suggestions

include/fiction/networks/views/input_ordering_view.hpp

hibenj · 2023-11-23T13:07:59Z

Do you want to have another look. Now all CIs pass.

marcelwa

Many thanks for your hard work on this PR 🙏 We're getting closer. There are still some issues to resolve here and there, but they are mainly concerning documentation.

test/networks/views/input_ordering_view.cpp

test/algorithms/physical_design/ortho_ordering_network.cpp

test/algorithms/network_transformation/inverter_substitution.cpp

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp

github-actions

clang-tidy made some suggestions

cli/cmd/physical_design/ortho_ordering.hpp

…duce_Input_Sort

marcelwa · 2023-12-04T11:44:50Z

cli/cmd/physical_design/ortho_ordering.hpp

Just a suggestion: Instead of doing a whole new command, you could expose input ordering as a flag for ortho if you wanted. It would reduce code duplication. If you rather have it this way, I'm okay with that, too.

cli/cmd/physical_design/ortho_ordering.hpp

docs/publications.rst

include/fiction/traits.hpp

test/algorithms/network_transformation/inverter_substitution.cpp

test/algorithms/physical_design/ortho_ordering_network.cpp

test/networks/views/input_ordering_view.cpp

marcelwa · 2023-12-04T12:33:55Z

test/networks/views/input_ordering_view.cpp

+    CHECK(nodes_order == expected_nodes_order);
+}
+
+TEST_CASE("Input_ordering consider all pis aig network", "[input-ordering-view]")


What about other network types? You could make this a TEMPLATE_TEST_CASE to test for multiple implementations.

If the network type changes also the nodes change, so also the ranking of pis can change.

hibenj and others added 9 commits April 11, 2023 10:04

first commit

08f3b5d

Input_Sort updated

a87623c

Save coloring as it was

77ea3ec

coloring updated

664f64c

Inerter balancing and tests

f2ca6f1

updated coloring

f45429a

Adjusted comments

4ee1a6f

Merge branch 'marcelwa:main' into Introduce_Input_Sort

0804779

Merge branch 'marcelwa:main' into Introduce_Input_Sort

7caa431

marcelwa self-requested a review April 14, 2023 14:11

marcelwa self-assigned this Apr 14, 2023

marcelwa added the enhancement New feature or request label Apr 14, 2023

Merge branch 'marcelwa:main' into Introduce_Input_Sort

ea1f37c

github-advanced-security bot found potential problems Apr 14, 2023

View reviewed changes

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp Fixed Show fixed Hide fixed

marcelwa requested changes Apr 17, 2023

View reviewed changes

hibenj and others added 5 commits April 20, 2023 10:26

inverter_balancing files updated

86b3960

input_ordering_view files updated

06da497

ortho_ordering_network files updated

13ccb94

Merge branch 'Introduce_Input_Sort' of https://github.com/hibenj/fiction

35c255b

into Introduce_Input_Sort

Merge branch 'marcelwa:main' into Introduce_Input_Sort

54b2952

test formated

2168301

github-advanced-security bot found potential problems Apr 20, 2023

View reviewed changes

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp Fixed Show fixed Hide fixed

hibenj added 2 commits April 20, 2023 17:05

updated cli command optimize with flag -i -> optimize inverters in gi…

e9cc58e

…ven logic network

adjusted the cli command optimize to inverterbalance

31015b5

marcelwa requested changes Apr 21, 2023

View reviewed changes

hibenj added 2 commits April 25, 2023 12:46

CLI command adjusted

ee47d56

Comments adjusted

9d8ddb7

github-actions bot reviewed Nov 21, 2023

View reviewed changes

experiments/DN_experiments/DN_experiments.cpp Outdated Show resolved Hide resolved

experiments/DN_experiments/DN_experiments.cpp Outdated Show resolved Hide resolved

include/fiction/algorithms/physical_design/ortho_ordering_network.hpp Outdated Show resolved Hide resolved

hibenj and others added 8 commits November 21, 2023 15:01

Merge branch 'main' into Introduce_Input_Sort

ba8c4cf

Merge branch 'main' into Introduce_Input_Sort

172efde

Clang Format Linter

9213096

small changes: corrected data types, readability, corrected headers

7cdba59

small changes: corrected data types, readability, corrected headers

23d2c4c

Documentation error corrected

68b1a23

Documentation error corrected

5887ecf

Linter CI

063507e

github-actions bot reviewed Nov 21, 2023

View reviewed changes

include/fiction/networks/views/input_ordering_view.hpp Show resolved Hide resolved

hibenj and others added 6 commits November 22, 2023 09:52

Tests updated

0b1018c

Tests updated

628f3ee

Readability and test added

8a53d00

Merge branch 'cda-tum:main' into Introduce_Input_Sort

9e4e3d3

CI run fix

1f1d82d

CI run fix

facc1c1

marcelwa requested changes Nov 27, 2023

View reviewed changes

Documentation and CLI commands updated

ea4c056

github-actions bot reviewed Nov 27, 2023

View reviewed changes

cli/cmd/physical_design/ortho_ordering.hpp Show resolved Hide resolved

cli/cmd/physical_design/ortho_ordering.hpp Show resolved Hide resolved

cli/cmd/physical_design/ortho_ordering.hpp Show resolved Hide resolved

cli/cmd/physical_design/ortho_ordering.hpp Show resolved Hide resolved

hibenj requested a review from marcelwa November 28, 2023 08:12

hibenj and others added 5 commits November 28, 2023 17:50

Small changes to enable equivalence checking

21308e8

Small changes to enable equivalence checking

02ca5bd

Merge branch 'main' into Introduce_Input_Sort

49293ee

Linter changes

02229ba

Merge remote-tracking branch 'origin/Introduce_Input_Sort' into Intro…

d15d1b8

…duce_Input_Sort

marcelwa requested changes Dec 4, 2023

View reviewed changes

hibenj added 2 commits December 8, 2023 10:55

Documentation updated

47d6741

Equivalence checking

a2edcc4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce input sort #183

Introduce input sort #183

hibenj commented Apr 14, 2023 •

edited

Loading

codecov bot commented Apr 14, 2023 •

edited

Loading

marcelwa left a comment

hibenj commented Apr 20, 2023

marcelwa commented Apr 21, 2023

marcelwa left a comment

codecov bot commented Nov 21, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

hibenj commented Nov 23, 2023

marcelwa left a comment

github-actions bot left a comment

marcelwa Dec 4, 2023

marcelwa Dec 4, 2023

hibenj Dec 10, 2023

Introduce input sort #183

Are you sure you want to change the base?

Introduce input sort #183

Conversation

hibenj commented Apr 14, 2023 • edited Loading

Description

Checklist:

codecov bot commented Apr 14, 2023 • edited Loading

Codecov Report

marcelwa left a comment

Choose a reason for hiding this comment

hibenj commented Apr 20, 2023

marcelwa commented Apr 21, 2023

marcelwa left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 21, 2023 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

hibenj commented Nov 23, 2023

marcelwa left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

marcelwa Dec 4, 2023

Choose a reason for hiding this comment

marcelwa Dec 4, 2023

Choose a reason for hiding this comment

hibenj Dec 10, 2023

Choose a reason for hiding this comment

hibenj commented Apr 14, 2023 •

edited

Loading

codecov bot commented Apr 14, 2023 •

edited

Loading

codecov bot commented Nov 21, 2023 •

edited

Loading