Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Improved performance of SAT-based clock number assignment #449

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Jun 1, 2024

Description

This PR improves the performance of the SAT instance by consistently using the critical path (instead of a random path) for symmetry breaking.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

…the critical path (instead of a random path) for symmetry breaking
@marcelwa marcelwa added the performance Performance improvements label Jun 1, 2024
@marcelwa marcelwa self-assigned this Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 98.23%. Comparing base (e365ed0) to head (58cdc22).

Files Patch % Lines
.../algorithms/physical_design/determine_clocking.hpp 33.33% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   98.26%   98.23%   -0.03%     
==========================================
  Files         220      220              
  Lines       30104    30105       +1     
  Branches     1470     1473       +3     
==========================================
- Hits        29582    29574       -8     
- Misses        522      531       +9     
Files Coverage Δ
.../algorithms/physical_design/determine_clocking.hpp 89.51% <33.33%> (-6.29%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e365ed0...58cdc22. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant