refactor: reads supported Foundry version from an environment variable

[arthurgousset]

Description

1. reads an environment variable (SUPPORTED_FOUNDRY_VERSION) defined at the celo-org (GitHub org) level.
2. updates the Foundry installation version to use the defined variable for consistency across workflows in celo-org/celo-monorepo and celo-org/developer-tooling.

The overall objective is to update Foundry versions in lock-steps. See more context on pros and cons in:

• Fix Foundry version across GitHub workflows #11032

Other changes

None.

Tested

Tested on CI. This only changes CI workflows.

Related issues

• Fixes Fix Foundry version across GitHub workflows #11032

Backwards compatibility

Yes.

Documentation

Yes in code comments and this PR description.

[arthurgousset]

Expect the workflows to fail, because the SUPPORTED_FOUNDRY_VERSION is not yet defined at the celo-org (GitHub org) level. Context #11032 (comment).

[arthurgousset]

Expect the workflows to pass, because the SUPPORTED_FOUNDRY_VERSION is defined at the celo-org (GitHub org) level. See Slack confirmation.

[arthurgousset]

Waiting to confirm whether I should merge this branch against master or release/core-contracts/12 .

[arthurgousset]

Converting this into a draft PR again. I'll merge this branch into release/core-contracts/12, but I need to cherry-pick my commits, and cut a new branch from release/core-contracts/12 that doesn't include the latest mento commits against master.

[arthurgousset]

That should be done with 8f039a2. Waiting for CI to pass before marking this as ready for review.

[arthurgousset]

CI didn't complete, because runner didn't pick the "Build & Integration Tests / Install dependencies" workflow.
Cancelled, and re-running failed jobs.

[arthurgousset]

All workflows are green, but waiting for "Protocol Compatibility" to report. Not sure why this is stuck at the moment.

[arthurgousset]

When I run the "Protocol Compatibility" command locally, the command passes:

$ yarn
$ yarn build
$ yarn --cwd packages/protocol test compatibility/

# ...
  76 passing (4s)
  2 pending

✨  Done in 196.13s.

Context:

celo-monorepo/.github/workflows/celo-monorepo.yml

Lines 220 to 222 in c870d49

	- name: Protocol Compatibility
	command: |
	yarn --cwd packages/protocol test compatibility/

[openzeppelin-code]

refactor: reads supported Foundry version from an environment variable

Generated at commit: e886bb107683aa146135035501c76583dbf748e3

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 3 0 15 41 61
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[arthurgousset]

The problem with the missing (or "expected") workflow was that the condition that is evaluated before running the steps could never evaluate to true here, because it was running against release/core-contracts/** branches.

Now that the condition includes release branches, this step can run:

celo-monorepo/.github/workflows/celo-monorepo.yml

Lines 160 to 164 in 3a0a771

	if: |
	github.base_ref == 'master' || contains(github.base_ref, 'release') || contains(github.base_ref, 'production') ||
	contains(needs.install-dependencies.outputs.all_modified_files, 'packages/protocol') ||
	contains(needs.install-dependencies.outputs.all_modified_files, ',package.json') ||
	contains(needs.install-dependencies.outputs.all_modified_files, ',yarn.lock') ||

The required changes was:

- github.base_ref == 'master' || contains(github.base_ref, 'production') ||
+ github.base_ref == 'master' || contains(github.base_ref, 'release') || contains(github.base_ref, 'production') ||

This was fixed in #11080, which was merged in the meantime.

The workflows are all green now ✅

[soloseng]

🚀