-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed role to give it more flexibility #5
Conversation
…e option to choose if you want a cluster or not
Maybe this also solves the problem for #1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I have some questions about your scenario first though.
@@ -30,3 +30,9 @@ thinlinc_tlsetup_migrate_conf: "old" | |||
# | |||
# The default value is null, which is equal to ansible_fqdn. | |||
thinlinc_agent_hostname: null | |||
|
|||
# Define if this is a standalone thinlinc environment or a cluster | |||
thinlinc_use_cluster: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does your scenario look like here? How is this different from just having a single agent specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Pierre,
I am using thinlinc on a single server only. When i tried to run the playbook for the first time on multiple servers (i have 2 servers running thinlinc) the hostnames of the servers were added to the two config files. Because the host is a master and a agent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. In that case I think your suggestion here is more of a workaround than a fix. If you try to deploy two multi-machine clusters then things would still break.
So I think we need to look at a proper fix for #1. :/
@@ -43,7 +43,7 @@ | |||
- name: Configure /vsmagent/agent_hostname | |||
tlconfig: | |||
param: /vsmagent/agent_hostname | |||
value: "{{ thinlinc_agent_hostname or ansible_fqdn }}" | |||
value: "{{ thinlinc_agent_hostname or ansible_hostname }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ansible_hostname
is not always an externally valid name, so I think we're just trading one issue for another here.
What scenario are you trying to fix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this was a bit overdone, ansible_fqdn was returning wrong values so i changed it to ansible_hostname.
The Web Access part of this was written by Michael Trip in PR #5. Co-authored-by: Samuel Mannehed <[email protected]>
I broke out the Web Access port-part of this PR to #40. |
Hello,
I added some features to the role to be more flexible in deployment.