Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-161 Fix Build #104

Merged
merged 9 commits into from
Aug 31, 2023
Merged

AF-161 Fix Build #104

merged 9 commits into from
Aug 31, 2023

Conversation

tleef42
Copy link
Contributor

@tleef42 tleef42 commented Aug 22, 2023 •
edited
Loading

This is a PR to run and debug GitHub workflows

Current changes:

  • Add CLI publishing to make sure the JSONs end up published before attempting to validate them

@tleef42 tleef42 changed the title Changes to validate command in Makefile Tinkering with the build Aug 22, 2023
@mehaase mehaase changed the title Tinkering with the build AF-161 Fix Build Aug 30, 2023
tleef42 and others added 3 commits August 30, 2023 21:41
@tleef42 @mehaase
Changed validate to make sure the json are published through the CLI …
131dc47 
…before validating corpus.
@mehaase
AF-161 Fix build
f0204a4 
- Install node dependencies in the test.yml workflow (it's needed for publishing JSONs so that we can validate
  flows in the corpus)
- Builder config changes:
    * windows_registry_key values should be a list of dictionaries, not a list of strings
    * file.size should be an int, not a string
- Validator changes:
    * The flow's "scope" property is required
    * Empty items should not be allowed in lists
    * Fix artifact required fields logic
    * Additional validation for hashes: the VMware TA2 was failing due to an invalid MD5 string, add regex for hashes
- Publisher changes:
    * Flow scope should emit the raw enum value, e.g. "threat-actor" not "Threat Actor"
    * Emit the entire STIX ID for each start ref, not just the GUID part
    * Add an implementation for merging a basic list of basic dicts (needed for windows_registry_key)
    * externals_refs: null properties should not be emitted
- Update all .afb files to pass builder's validation
@mehaase
Fix build
71139f2 
- Fix broken python test
- Add workaround for using Browser.ts in non-browser context
- Run `make docs-examples` to update example_flows.rst
@mehaase
Make this flaky test more robust
890aca9
@mehaase
Fix build
b087e43 
Move JSON validation from python build to python+node build
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/attack_flow/__init__.py ø
src/attack_flow/cli.py ø
src/attack_flow/graphviz.py ø
src/attack_flow/matrix.py ø
src/attack_flow/mermaid.py ø
src/attack_flow/schema.py ø

📢 Thoughts on this report? Let us know!.

@mehaase mehaase marked this pull request as ready for review August 31, 2023 03:08
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 26 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mikecarenzo mikecarenzo merged commit 77b26d2 into main Aug 31, 2023
6 of 8 checks passed
@mikecarenzo mikecarenzo deleted the af161-build-fixes branch August 31, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehaase mehaase mehaase left review comments

@mikecarenzo mikecarenzo mikecarenzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tleef42 @mehaase @mikecarenzo