AF-180: Account for Device Pixel Ratio when Rendering Graphics #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mehaase
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
I compared rendering in the 2.0 builder side-by-side with this branch and the difference is amazing!
I don't have any low dpi screens to test switching back and forth, nor do i understand most of the canvas magic that makes this work, but this is a huge improvement. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sharpens graphics on monitors with high pixel density (like Apple Retina displays).
Shaper Graphics
This PR updates
BlockDiagramso that it accounts for the device's current pixel ratio.This PR also introduces the
"dppx-change"event to theBrowserutility class. Now, developers can subscribe to changes to the device's pixel ratio. (This usually occurs when dragging the browser to and from monitors with different pixel densities.) This new event is used byBlockDiagramto re-render the chart in such cases.