Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-126 Location Validation #82

Merged
merged 4 commits into from
Jul 20, 2023
Merged

AF-126 Location Validation #82

merged 4 commits into from
Jul 20, 2023

Conversation

nikorev
Copy link
Contributor

@nikorev nikorev commented Jul 18, 2023

Still in-progress:

  • location.latitude and longitude: if you specify one, you have to specify the other
  • location requires one of: region, country, lat/lon
  • region or country could be title attributes if name is null

What exactly is a title attribute? From the UI perspective, is the title attribute shown as the bold text in the following picture?

image

@nikorev nikorev requested a review from mikecarenzo July 18, 2023 18:27
@nikorev
Copy link
Contributor Author

nikorev commented Jul 20, 2023

Following discussion with @mikecarenzo, changing the title attribute requires modifying the is_primary behavior; in its current state it cannot be updated (read-only), and would require enough changes that it should warrant a separate ticket/issue.

With that being said, we can merge this branch based off the first two bullet points, as those are complete. I'll mark this PR as ready.

@nikorev nikorev marked this pull request as ready for review July 20, 2023 17:45
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikecarenzo mikecarenzo merged commit 42bca91 into main Jul 20, 2023
3 of 4 checks passed
@mikecarenzo mikecarenzo deleted the AF-126_location_validation branch July 20, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecarenzo mikecarenzo mikecarenzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikorev @mikecarenzo