Af149 opinion #86
Merged
Af149 opinion #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st one object; handled non-boolean enumeration values
mikecarenzo
requested changes
Jul 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mikecarenzo
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got stuck for a while trying to over-engineer the publisher, only to realize it was best to keep it simple and build on it later.
The main concern is when an object that uses an Enum value is published, the node as as they appear in the builder. i.e. if we wanted to make an enumeration such as:
value: [ ['internal_use_only': 'external_use_only'] ]The node would hold
value: 'external_use_only'rather thanvalue: 'internal_use_only'in order to correctly assign a value within the schema of the object. At this moment, we don't have any object whose 'internal' and 'external' enumeration values differ, so keeping it simple for now.Changes: