AF-127 Text Trimming #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No. For now, simply trim trailing and leading whitespace. In the future, users won't be able to use the enter key on fields flagged as single line. |
|
Was missing one trim call. Marking branch as ready:
|
|
Kudos, SonarCloud Quality Gate passed!
|
mikecarenzo
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trims leading and trailing whitespace via .trim(). I see there is a future ticket (AF-170) to handle single vs multi-line text fields. Should I strip all newline characters for now, or in the future will the UI prevent users from creating new lines (i.e. hitting enter) inside of single-line text fields?
Still testing to verify I hit all spots where we're looking to trim, marking as draft for now.