Add a command line tool for publishing .afb files to .json #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mehaase
commented
Jul 31, 2023
mehaase
commented
- The script is implemented as a new build target for Vue, which is better than creating a standalone .js or .ts script because it integrates natively with the existing code base.
- The main browser dependency to work around is the canvas context in Fonts.ts. The solution is to define new interfaces for Font and FontStsore and add stub implementations that are used when we're not running in a browser.
- Remove .json files from the corpus (and .gitignore corpus/*.json).
- Set GitHub action to generate .json files at build time
- Add developer docs showing how to use this command line tool.
- The script is implemented as a new build target for Vue, which is better than creating a standalone .js or .ts script because it integrates natively with the existing code base. - The main browser dependency to work around is the canvas context in Fonts.ts. The solution is to define new interfaces for Font and FontStsore and add stub implementations that are used when we're not running in a browser. - Remove .json files from the corpus (and .gitignore corpus/*.json). - Set GitHub action to generate .json files at build time - Add developer docs showing how to use this command line tool.
mehaase
force-pushed
the
AF-118-publish-jsons-cli
branch
3 times, most recently
from
2e717f9
to
cb2bca0
Compare
mehaase
force-pushed
the
AF-118-publish-jsons-cli
branch
from
cb2bca0
to
69f380e
Compare
mikecarenzo
requested changes
Aug 7, 2023
src/attack_flow_builder/src/assets/scripts/BlockDiagram/Utilities/Fonts.ts
Outdated
Show resolved
Hide resolved
Remove unused d3 import
|
Kudos, SonarCloud Quality Gate passed!
|
mikecarenzo
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.