Use evm inputs for issuers #2226
Conversation
kattylucy
force-pushed
the
use_evm_inputs_for_issuers
branch
from
40d748f
to
acc1043
Compare
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
use_evm_inputs_for_issuers
branch
from
acc1043
to
02f7a57
Compare
| function handleBlur(e: React.FocusEvent<HTMLInputElement>) { | ||
| const address = e.target.value | ||
| if (address && !exists) { | ||
| onAdd(addressToHex(address)) |
There was a problem hiding this comment.
Is this the desired behaviour? If so, it should check that it's a valid address (check if truncated is truthy)
kattylucy
force-pushed
the
use_evm_inputs_for_issuers
branch
from
02f7a57
to
323355f
Compare
| value?: string | ||
| onChange: (e: React.ChangeEvent<HTMLInputElement>) => void | ||
| onBlur?: (e: React.FocusEvent<HTMLInputElement>) => void |
There was a problem hiding this comment.
I don't think you have to explicitly declare these three types, they should already be included in the type React.InputHTMLAttributes<HTMLInputElement
There was a problem hiding this comment.
Yes, you are right ! - thanks
There was a problem hiding this comment.
Great job!
Can you please make sure the add address button is vertically centered? And the same for the pool managers?
In the fees tab I noticed that when I use an EVM address it's saying "Invalid address", I think you might need to adjust the validation to make it work for EVM
|
Nice work Katty! Just a few more things to clarify and then I think it's good to go! I think we can now remove the dropdown next to the input since the network is now implied by the address, buuuut @hieronx will we still need it to differentiate between the different EVM chains for liquidity pools? I think we also need some kind of icon for the evm wallets here, maybe just the ethereum logo for now? I also tried submitting the transaction but it failed: |
Yeah we still need to differentiate between EVM chains. For the Centrifuge network, the input could be either an EVM address or a Substrate/Centrifuge address. For all other networks, it's always an EVM address. |
|
Yeah we still need to differentiate between EVM chains. How do we currently differentiate the two? |
|
@kattylucy that was in response to Sophia's question. The dropdown is for selecting the network |
Use the address input that we have for CFG transfers, that supports both EVM addresses and Centrifuge addresses
#2221
Approvals
Impact
Pool managers on Create pool page
Investor input for Centrifuge Chain on Investors tab
AO wallets on Access tab
Receiving address on Fees tab