Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gray background to loan pages #2256

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Add gray background to loan pages #2256

merged 1 commit into from
Jul 2, 2024

Conversation

kattylucy
Copy link
Contributor

Add gray background to fill 100vh in:

  • assets overview page
  • asset page

This pull request...

#2248

  • [ x ] Dev
  • Dev
  • Designer
  • [ x ] Product

I will highly suggest that we work on fixing the nav bar on the right side - see screenshot

Screenshot 2024-06-27 at 2 27 03 PM Screenshot 2024-06-27 at 2 26 52 PM Screenshot 2024-06-27 at 2 06 55 PM

Copy link

github-actions bot commented Jun 27, 2024

PR deployed in Google Cloud
URL: https://pr2256-app-ff-production.k-f.dev
Commit #: af50d3b
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Jun 27, 2024

PR deployed in Google Cloud
URL: https://app-pr2256.k-f.dev
Commit #: af50d3b
To access the functions directly check the corresponding deploy Action

@hieronx
Copy link
Contributor

hieronx commented Jul 1, 2024

@kattylucy Apologies if that was unclear, but I was referring to the pool overview, not the asset overview. So the pages that should have the gray background filled to the bottom are

  • The asset detail page, that you already did:/pools/4139607887/assets/1
  • The pool overview page: /pools/4139607887

But not the asset list/overview page,/pools/4139607887/assets

The asset detail page looks good though!

@kattylucy
Copy link
Contributor Author

Ah gotcha! Reverting the changes now - just a quick question, is there an specific pool in which you see the gray background being cut off? Im checking different pools/:poold paths and I see the gray background covering the whole right side in all the cases @hieronx

@kattylucy kattylucy force-pushed the gray_bg_fixes branch 2 times, most recently from aa93f2b to 7f1f3c8 Compare July 2, 2024 14:33
@hieronx
Copy link
Contributor

hieronx commented Jul 2, 2024

@kattylucy it cuts off for me here: https://app.centrifuge.io/pools/0x55d86d51Ac3bcAB7ab7d2124931FbA106c8b60c7

Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kattylucy kattylucy merged commit 22b57c9 into main Jul 2, 2024
13 checks passed
@kattylucy kattylucy deleted the gray_bg_fixes branch July 2, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants